From 241d8d0c860ed5b541cb93780b67f2ec548696c1 Mon Sep 17 00:00:00 2001 From: ziyi chen Date: Thu, 13 Feb 2025 09:29:28 -0500 Subject: [PATCH] update --- Makefile | 9 +++++---- .../src/connector/unity_catalog_connector.cpp | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 1e80cc95f9f..7841a450325 100644 --- a/Makefile +++ b/Makefile @@ -91,7 +91,7 @@ allconfig: $(call config-cmake-release, \ -DBUILD_BENCHMARK=TRUE \ -DBUILD_EXAMPLES=TRUE \ - -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite;fts;delta;iceberg" \ + -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite;fts;delta;iceberg;unity-catalog" \ -DBUILD_JAVA=TRUE \ -DBUILD_NODEJS=TRUE \ -DBUILD_PYTHON=TRUE \ @@ -106,7 +106,7 @@ alldebug: $(call run-cmake-debug, \ -DBUILD_BENCHMARK=TRUE \ -DBUILD_EXAMPLES=TRUE \ - -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite;fts;delta;iceberg" \ + -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite;fts;delta;iceberg;unity-catalog" \ -DBUILD_JAVA=TRUE \ -DBUILD_NODEJS=TRUE \ -DBUILD_PYTHON=TRUE \ @@ -195,7 +195,7 @@ example: extension-test-build: $(call run-cmake-relwithdebinfo, \ - -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite;fts;delta;iceberg" \ + -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite;fts;delta;iceberg;unity-catalog" \ -DBUILD_EXTENSION_TESTS=TRUE \ -DBUILD_TESTS=TRUE \ ) @@ -227,7 +227,7 @@ extension-debug: extension-release: $(call run-cmake-release, \ - -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite;fts;delta;iceberg" \ + -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite;fts;delta;iceberg;unity-catalog" \ -DBUILD_KUZU=FALSE \ ) @@ -270,6 +270,7 @@ clean-extension: cmake -E rm -rf extension/fts/build cmake -E rm -rf extension/delta/build cmake -E rm -rf extension/iceberg/build + cmake -E rm -rf extension/unity-catalog/build clean-python-api: cmake -E rm -rf tools/python_api/build diff --git a/extension/unity-catalog/src/connector/unity_catalog_connector.cpp b/extension/unity-catalog/src/connector/unity_catalog_connector.cpp index 41325bd14d9..12341e3e3d8 100644 --- a/extension/unity-catalog/src/connector/unity_catalog_connector.cpp +++ b/extension/unity-catalog/src/connector/unity_catalog_connector.cpp @@ -15,7 +15,6 @@ void UnityCatalogConnector::connect(const std::string& dbPath, const std::string executeQuery("install delta;"); executeQuery("load delta;"); executeQuery("install delta;"); - auto query = DuckDBUnityCatalogSecretManager::getSecret(context); executeQuery(DuckDBUnityCatalogSecretManager::getSecret(context)); executeQuery(common::stringFormat("attach '{}' as {} (TYPE UC_CATALOG, read_only);", dbPath, catalogName));