Skip to content

Commit

Permalink
fix: in the image-spec validations and docs (#2302)
Browse files Browse the repository at this point in the history
## Description
fix: in the image-spec validations and docs

## REMINDER: Tag Reviewers, so they get notified to review

## Is this change user facing?
YES

## References (if applicable)
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
<!-- You can auto-close issues by putting "Fixes #XXXX" here. -->
  • Loading branch information
leoporoli authored Mar 27, 2024
1 parent 5fab14a commit 5eb72f2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func NewImageSpec() *kurtosis_type_constructor.KurtosisTypeConstructor {
IsOptional: true,
ZeroValueProvider: builtin_argument.ZeroValueProvider[starlark.String],
Validator: func(value starlark.Value) *startosis_errors.InterpretationError {
return builtin_argument.NonEmptyString(value, ImageRegistryUsernameAttr)
return builtin_argument.NonEmptyString(value, ImageRegistryPasswordAttr)
},
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ config = ServiceConfig(
image = ImageSpec(
# The name of the image that needs to be pulled qualified with the registry
# MANDATORY
name = "my.registry.io/my-user/my-image",
image = "my.registry.io/my-user/my-image",

# The username that will be used to pull the image from the given registry
# OPTIONAL
Expand Down

0 comments on commit 5eb72f2

Please sign in to comment.