Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.11.1: Maintenance updates #79

Merged
merged 6 commits into from
Jun 7, 2024
Merged

v0.11.1: Maintenance updates #79

merged 6 commits into from
Jun 7, 2024

Conversation

kurone-kito
Copy link
Owner

@kurone-kito kurone-kito commented Jun 7, 2024

Features

ESLint

  • 1f874db: migrated the extends the eslint-plugin-json to v4

Bug fixes

ESLint

  • dfc05e4: fixed the rules from eslint-plugin-node to eslint-plugin-n

Other updates

ALL

  • aeecd38: Bumped the version number
  • 19ce63a: updated the dependencies

root

  • 2515756: increased the specified Node.js version
  • b18b1da: improved the git attributes config

Summary by CodeRabbit

  • New Features

    • Updated Node.js version to 18.20.3 for improved performance and security.
    • Added new ESLint plugins: eslint-plugin-jsx-a11y, eslint-plugin-markdownlint, eslint-plugin-n, and eslint-plugin-oxlint.
  • Bug Fixes

    • Replaced plugin:json/recommended with plugin:json/recommended-legacy in ESLint configurations.
  • Dependency Updates

    • Updated various dependencies in package.json files for better stability and new features.
    • Incremented package versions across multiple configurations for consistency and improvements.

@kurone-kito kurone-kito added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request dependencies add, remove, or update the dependencies labels Jun 7, 2024
@kurone-kito kurone-kito self-assigned this Jun 7, 2024
Copy link

coderabbitai bot commented Jun 7, 2024

Walkthrough

The recent updates focus on several key areas: improving Node.js version consistency across various configuration files, updating dependency versions in multiple package.json files, and refining ESLint configurations by adjusting rules and adding/removing plugins. These changes collectively enhance the project's maintainability, compatibility, and adherence to best practices.

Changes

Files/Paths Change Summary
.gitattributes Added .imgbotconfig to export-ignore list.
.node-version, .nvmrc, .tool-versions Updated Node.js version from 18.20.2 to 18.20.3.
package.json Updated versions of various dependencies like eslint, prettier, and related plugins.
packages/commitlint-config/package.json Incremented version from "0.11.0" to "0.11.1".
packages/cspell-config/package.json Updated @cspell/cspell-types and cspell dependencies to 8.8.4 from 8.8.1.
packages/eslint-config-base/.eslintrc.yml Changed ESLint plugin for JSON and updated rule references from node/ to n/.
packages/eslint-config-base/README.md Added/removed ESLint plugins: removed eslint-plugin-node, added eslint-plugin-markdownlint, etc.
packages/eslint-config-base/package.json Updated dependency versions for several ESLint plugins and prettier.
packages/eslint-config-react/.eslintrc.yml Replaced node/no-unpublished-import with n/no-unpublished-import in overrides sections.
packages/eslint-config-react/README.md Added eslint-plugin-jsx-a11y, eslint-plugin-markdownlint, etc., removed eslint-plugin-node.
packages/eslint-config-react/package.json Updated version from "0.11.0" to "0.11.1" and various dependencies.
packages/lint-staged-config/package.json Incremented version from "0.11.0" to "0.11.1".
packages/markdownlint-config/package.json Incremented version from "0.11.0" to "0.11.1".
packages/prettier-config/package.json Updated version from "0.11.0" to "0.11.1" and prettier dependency to 3.3.1.
packages/typescript-config/package.json Updated version from "0.11.0" to "0.11.1" and dependencies like @typescript-eslint/parser.

Poem

In the realm of code so bright,
Updates bring new light,
Node.js now more secure,
ESLint rules refined and pure,
Dependencies fresh and neat,
Our project skips a beat,
With every change, we soar,
To maintain and explore!


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3dd7c13 and aeecd38.

Files ignored due to path filters (2)
  • .yarn/sdks/prettier/package.json is excluded by !.yarn/**, !.yarn/**/*
  • yarn.lock is excluded by !**/*.lock
Files selected for processing (17)
  • .gitattributes (1 hunks)
  • .node-version (1 hunks)
  • .nvmrc (1 hunks)
  • .tool-versions (1 hunks)
  • package.json (4 hunks)
  • packages/commitlint-config/package.json (1 hunks)
  • packages/cspell-config/package.json (2 hunks)
  • packages/eslint-config-base/.eslintrc.yml (2 hunks)
  • packages/eslint-config-base/README.md (1 hunks)
  • packages/eslint-config-base/package.json (4 hunks)
  • packages/eslint-config-react/.eslintrc.yml (2 hunks)
  • packages/eslint-config-react/README.md (1 hunks)
  • packages/eslint-config-react/package.json (4 hunks)
  • packages/lint-staged-config/package.json (1 hunks)
  • packages/markdownlint-config/package.json (1 hunks)
  • packages/prettier-config/package.json (2 hunks)
  • packages/typescript-config/package.json (2 hunks)
Files skipped from review due to trivial changes (11)
  • .gitattributes
  • .node-version
  • .nvmrc
  • .tool-versions
  • packages/commitlint-config/package.json
  • packages/cspell-config/package.json
  • packages/eslint-config-react/package.json
  • packages/lint-staged-config/package.json
  • packages/markdownlint-config/package.json
  • packages/prettier-config/package.json
  • packages/typescript-config/package.json
Additional comments not posted (22)
packages/eslint-config-base/README.md (3)

26-26: Added eslint-plugin-markdownlint to enhance Markdown linting capabilities.


27-27: Added eslint-plugin-n as part of the migration from eslint-plugin-node.


28-28: Added eslint-plugin-oxlint to extend linting rules.

packages/eslint-config-react/README.md (4)

25-25: Added eslint-plugin-jsx-a11y to enhance accessibility linting for React projects.


27-27: Added eslint-plugin-markdownlint to enhance Markdown linting capabilities.


28-28: Added eslint-plugin-n as part of the migration from eslint-plugin-node.


29-29: Added eslint-plugin-oxlint to extend linting rules.

package.json (2)

3-3: Updated version number to 0.11.1.


Line range hint 54-89: Updated various dependencies to their latest versions.

packages/eslint-config-react/.eslintrc.yml (2)

30-30: Updated rule n/no-unpublished-import to reflect migration from eslint-plugin-node to eslint-plugin-n.


46-46: Updated rule n/no-unpublished-import to reflect migration from eslint-plugin-node to eslint-plugin-n.

packages/eslint-config-base/package.json (8)

3-3: Version update to 0.11.1 aligns with the PR objectives.


39-39: Update of @cspell/eslint-plugin to ^8.8.4 aligns with the PR objectives.


41-42: Updates of @typescript-eslint/eslint-plugin and @typescript-eslint/parser to ^7.12.0 align with the PR objectives.


53-53: Update of eslint-plugin-jsdoc to ^48.2.9 aligns with the PR objectives.


54-54: Update of eslint-plugin-json to ^4.0.0 aligns with the PR objectives.


57-58: Updates of eslint-plugin-n to ^17.8.1 and eslint-plugin-oxlint to ^0.4.0 align with the PR objectives.


61-61: Update of prettier to ^3.3.1 aligns with the PR objectives.


78-78: Update of eslint-plugin-json to >=4.x.x in peer dependencies aligns with the PR objectives.

packages/eslint-config-base/.eslintrc.yml (3)

8-8: Update to use plugin:json/recommended-legacy aligns with the PR objectives.


129-129: Update of n/no-missing-import rule to off aligns with the PR objectives.


133-133: Update of n/no-unsupported-features/es-syntax rule to off aligns with the PR objectives.

@kurone-kito kurone-kito merged commit 01f478f into main Jun 7, 2024
15 checks passed
@kurone-kito kurone-kito deleted the maintenance branch June 7, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies add, remove, or update the dependencies documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant