Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative updates #62

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Cumulative updates #62

merged 5 commits into from
Jan 29, 2024

Conversation

kurone-kito
Copy link
Owner

Features

  • 3a28118: (ALL) update the dependencies
  • a2b61ea: (lint-staged) added the option that the cache location to the eslint

Other updates

  • 9655750: (root) migrated the husky configurations to v9
  • 0db2adb: (root) linted the JSON files
  • 8fe7b65: (root) improved the git attributes configuration

@kurone-kito kurone-kito added enhancement New feature or request dependencies add, remove, or update the dependencies labels Jan 29, 2024
@kurone-kito kurone-kito self-assigned this Jan 29, 2024
Copy link
Contributor

reviewpad bot commented Jan 29, 2024

AI-Generated Summary: This pull request includes several changes mostly pertaining to dependency updates and code formatting.

In the .husky/pre-commit file, the line calling the husky.sh script was removed which may impact the pre-commit process.

Stylistic changes were applied to the tsconfig.json file for consistent code formatting, specifically adding trailing commas where necessary. Along the same lines, formatting enhancements were also made to the 'tsconfig.json' file in the eslint-config-base package.

In the .gitattributes file, changes were made to the files/directories that we want Git to ignore during certain operations.

Dependency updates were made in the package.json files of the cspell-config, typescript-config and eslint-config-react packages primarily involving minor version increments. Dependency updates were also found in the package.json file in the root directory and prettier dependency in .yarn/sdks/prettier/package.json. In the eslint-config-base package, the version numbers of various packages listed in the devDependencies were updated.

Changes were observed in the lint-staged configuration in the lint-staged.config.yml file whereby the command for eslint was updated to specify the cache location.

The .husky/commit-msg file had two lines removed which are essential for loading Husky sh configuration affecting the commit rules.

The effect of these changes mainly includes code decoration, maintenance and potential operational improvements, however, it's recommended to test the entire solution post merging this pull request to confirm and validate the impact of these changes.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review and removed dependencies add, remove, or update the dependencies labels Jan 29, 2024
@kurone-kito kurone-kito merged commit b6b8582 into main Jan 29, 2024
11 checks passed
@kurone-kito kurone-kito deleted the cumulative-updates branch January 29, 2024 06:14
Copy link
Contributor

reviewpad bot commented Jan 29, 2024

📈 Pull Request Metrics

💻 Coding Time: 15 days

@kurone-kito kurone-kito mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant