Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(config): setup testing configuration and add first test #653

Merged
merged 17 commits into from
Jan 23, 2025

Conversation

DanneelsSophie
Copy link
Contributor

@DanneelsSophie DanneelsSophie commented Jan 17, 2025

Description:

  • Test Setup:

    • Configured Vitest for unit testing with Angular and integrated it into GitHub Actions for continuous integration.
    • Configured to automatically run tests CI configuration (ci.yml)
  • SellerForm Tests:

    • Added initial tests for SellerForm component to verify:
      • Correct form rendering and input fields.
      • handleSubmit is triggered on form submission.
      • Error messages are displayed when errorForm.hasError is true.
      • Correct values are passed to refs after form input.

@DanneelsSophie DanneelsSophie changed the title add configuration test and add one test test(config): add configuration test and add one test Jan 17, 2025
@DanneelsSophie DanneelsSophie changed the title test(config): add configuration test and add one test test(config): setup testing configuration and add first test Jan 17, 2025
server/apps/frontend/tsconfig.json Outdated Show resolved Hide resolved
@xballoy
Copy link
Contributor

xballoy commented Jan 21, 2025

@DanneelsSophie can you also add a short description to your PR and fix the conflicts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this file, there should be no root package.json as this is no node app (only server)

server/package.json Outdated Show resolved Hide resolved
@xballoy
Copy link
Contributor

xballoy commented Jan 23, 2025

@DanneelsSophie one last conflict then it's good!

@xballoy xballoy merged commit 60e4e31 into main Jan 23, 2025
1 check passed
@xballoy xballoy deleted the test/frontend branch January 23, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants