ability to setup host using own postgress and ability to set custom storageclass and size #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nushkovg added some more fixes and abilities |
|
@nushkovg would be glad if you can take a look here |
nushkovg
reviewed
Jul 15, 2024
Comment on lines
+19
to
+22
| securityContext: | ||
| fsGroup: 1001 | ||
| runAsUser: 1001 | ||
| runAsGroup: 1001 |
There was a problem hiding this comment.
Does the deployment face any issues without these permissions?
There was a problem hiding this comment.
yes no permissions to write to local storage
There was a problem hiding this comment.
Can we make this optional? Only when it's local storage. The other stuff looks good.
Comment on lines
+42
to
+43
| ## @param outline.fileStorage.storageClassName The storageclass name to use default "". | ||
| ## @param outline.fileStorage.storageSize The storageclass size to use default 250Gi. |
There was a problem hiding this comment.
Did you use the bitnami-helm-readme-generator for this?
There was a problem hiding this comment.
no with hands its 2 rows
|
@nushkovg done as you requested |
nushkovg
requested changes
Jul 18, 2024
Comment on lines
+19
to
+22
| securityContext: | ||
| fsGroup: 1001 | ||
| runAsUser: 1001 | ||
| runAsGroup: 1001 |
There was a problem hiding this comment.
Can we make this optional? Only when it's local storage. The other stuff looks good.
nushkovg
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.