Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump opentelemetry dependencies #819

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Jul 9, 2024

Description

Test

  • CI.
  • Performing docker-compose local deployment and testing: Tracing is broken, as jaeger fails to connect with otel-collector. This is because we aren't pinning jaeger.
  • end-to-end tests: broken for latest jaeger-operator-2.54.0. Working for jaeger-operator-2.49.0, the one we list as supported in https://docs.kubewarden.io/reference/dependency-matrix.

Additional Information

Tradeoff

Potential improvement

viccuad added 6 commits July 8, 2024 11:55
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.90%. Comparing base (82b7b81) to head (2ec8ce6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   54.90%   54.90%           
=======================================
  Files          16       16           
  Lines         765      765           
=======================================
  Hits          420      420           
  Misses        345      345           
Flag Coverage Δ
integration-tests 47.84% <ø> (ø)
unit-tests 32.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viccuad viccuad marked this pull request as ready for review July 10, 2024 11:53
@viccuad viccuad requested a review from a team as a code owner July 10, 2024 11:53
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@viccuad viccuad merged commit 1df0a40 into kubewarden:main Jul 10, 2024
13 checks passed
@viccuad viccuad deleted the otel-omnibus branch July 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants