-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce group policies #814
Conversation
2b57b1e
to
e0f165e
Compare
@fabriziosestito thanks for the review, I've addressed all the feedback you gave |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
+ Coverage 54.90% 58.45% +3.54%
==========================================
Files 16 17 +1
Lines 765 994 +229
==========================================
+ Hits 420 581 +161
- Misses 345 413 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one typo to fix.
Also, the latest commit is not a conventional commit.
@fabriziosestito I've addressed your comment. As for the commit format, I plan to squash all of them into a single commit. I'm not doing semantic git commits right now |
I think the current code is doing pretty good. I've implemented all the missing TODOs except for these ones:
|
Another update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really the last change I'm going to make to this PR. With 31b6539 I've introduced a dedicated Rust type to identify policies. We're no longer using strings. |
89891ea
to
31b6539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @flavio love the latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
7a13d6d
to
e3d3568
Compare
Last round of cleanups:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
94841fe
to
b2300e6
Compare
Allow multiple Kubewarden policies to be grouped together using an evaluation expression. This implents the RFC https://github.com/kubewarden/rfc/blob/main/rfc/0020-policy-group.md Signed-off-by: Flavio Castelli <fcastelli@suse.com> Co-authored-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
b2300e6
to
f5e8b1a
Compare
Allow multiple Kubewarden policies to be grouped together using an evaluation expression.
This PR poses the bases required to implement https://github.com/kubewarden/rfc/blob/main/rfc/0020-policy-group.md
Part of kubewarden/kubewarden-controller#798