Fix : Cue package changes after 1.10 version upgrade of vela-core #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoop2811
requested review from
barnettZQG,
FogDong,
dhiguero,
wangyikewxgm and
wonderflow
as code owners
anoop2811
changed the title
FogDong
reviewed
Feb 11, 2025
| @@ -9,7 +9,7 @@ parameter: { | |||
| kind: string | |||
| apiVersion: string | |||
| } | |||
| response: ql.#Read & { | |||
| response: query.#Read & { | |||
There was a problem hiding this comment.
If we're changing to the new package, we also need to add $params to the input body, and $returns to get the output. You can check this as an example: https://github.com/kubevela/kubevela/blob/master/vela-templates/definitions/internal/workflowstep/collect-service-endpoints.cue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #769