MTV-2025 | Prevent NICs wrong mapping during migration #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
+ Coverage 15.45% 15.51% +0.05%
==========================================
Files 112 112
Lines 23377 23692 +315
==========================================
+ Hits 3613 3675 +62
- Misses 19479 19730 +251
- Partials 285 287 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnecas
reviewed
Feb 19, 2025
mnecas
reviewed
Feb 19, 2025
Hazanel
force-pushed
the
nics-switch-br
branch
from
19398d2 to
712bb8d
Compare
mnecas
reviewed
Feb 19, 2025
mnecas
reviewed
Feb 19, 2025
Issue: When migrating VMs with multiple NICs when mapping the order must match that of the source VM Fix: Create a temp udev.rule file with temporarly NICs names with precedence over the "org" udev rule file - that will overcome the BOOT collisions. After udev applies the temp names and omitting the collisions issue it'll apply the desired names. Ref: https://issues.redhat.com/browse/MTV-2025 Signed-off-by: ehazan <ehazan@redhat.com>
Hazanel
force-pushed
the
nics-switch-br
branch
from
712bb8d to
5d22f4b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When migrating VMs with multiple NICs when mapping the order must match that of the source VM
Fix:
Create a temp udev.rule file with temporarly NICs names with precedence over the "org" udev rule file - that will overcome the BOOT collisions. After udev applies the temp names and omitting the collisions issue it'll apply the desired names.
Ref: https://issues.redhat.com/browse/MTV-2025