Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert shared disks in main #1364

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Feb 18, 2025

Revert of #1318 for main

@mnecas mnecas requested a review from yaacov as a code owner February 18, 2025 12:11
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 15.46%. Comparing base (f1fe5d0) to head (b163cd8).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/plan/migration.go 0.00% 2 Missing ⚠️
pkg/controller/plan/adapter/vsphere/builder.go 0.00% 1 Missing ⚠️
pkg/controller/plan/adapter/vsphere/client.go 0.00% 1 Missing ⚠️
pkg/controller/plan/kubevirt.go 0.00% 1 Missing ⚠️
pkg/controller/plan/scheduler/vsphere/scheduler.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1364    +/-   ##
========================================
  Coverage   15.45%   15.46%            
========================================
  Files         112      112            
  Lines       23377    23692   +315     
========================================
+ Hits         3613     3664    +51     
- Misses      19479    19743   +264     
  Partials      285      285            
Flag Coverage Δ
unittests 15.46% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas merged commit 90b8be3 into kubev2v:main Feb 18, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants