feat: update kkcore CRDs #2410
Open
feat: update kkcore CRDs #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubesphere-prow
bot
added
release-note
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dbbDylan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubesphere-prow
bot
added
the
size/XXL
|
redscholar
reviewed
Sep 19, 2024
Comment on lines
+83
to
+108
| // GetHostsFromGroup flatten a specific `Inventory` group with de-duplication. | ||
| func GetHostsFromGroup(inv *Inventory, groupName string, unavailableHosts, unavailableGroups map[string]struct{}) []string { | ||
| var hosts = make([]string, 0) | ||
| if v, ok := inv.Spec.Groups[groupName]; ok { | ||
| unavailableGroups[groupName] = struct{}{} | ||
| for _, cg := range v.Groups { | ||
| if _, exist := unavailableGroups[cg]; !exist { | ||
| unavailableGroups[cg] = struct{}{} | ||
| hosts = append(hosts, GetHostsFromGroup(inv, cg, unavailableHosts, unavailableGroups)...) | ||
| } | ||
| } | ||
|
|
||
| validHosts := make([]string, 0) | ||
| for _, hostName := range v.Hosts { | ||
| if _, ok := inv.Spec.Hosts[hostName]; ok { | ||
| if _, exist := unavailableHosts[hostName]; !exist { | ||
| unavailableHosts[hostName] = struct{}{} | ||
| validHosts = append(validHosts, hostName) | ||
| } | ||
| } | ||
| } | ||
| hosts = append(hosts, validHosts...) | ||
| } | ||
|
|
||
| return hosts | ||
| } |
There was a problem hiding this comment.
move in variable package
redscholar
reviewed
Sep 29, 2024
There was a problem hiding this comment.
should not set as a crd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind design
What this PR does / why we need it:
Update kkcore CRDs for CAPKK
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?