Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document feature gates for kubeadm #28788

Closed
sftim opened this issue Jul 4, 2021 · 10 comments
Closed

Document feature gates for kubeadm #28788

sftim opened this issue Jul 4, 2021 · 10 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Jul 4, 2021

This is a Feature Request

What would you like to be added
Document all the feature gates for kubeadm

Why is this needed
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ should be a list of feature gates for at least all in-tree tools. I'm not sure if we count kubeadm as in-tree but it's certainly a core part of Kubernetes in terms of how we document things.

If we don't document the kubeadm feature gates in
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ then instead
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ should hyperlink to a page that does.

Comments
Prompted by kubernetes/enhancements#2568 (comment)
/sig cluster-lifecycle

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 4, 2021
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 4, 2021
@sftim
Copy link
Contributor Author

sftim commented Jul 4, 2021

/language en
/kind feature

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 4, 2021
@neolit123
Copy link
Member

neolit123 commented Jul 4, 2021

commented here:
kubernetes/enhancements#2568 (comment)

historically, kubeadm has not been much of a FG user, but once a feature moves to beta we always document it at k8s.io.

if anyone wants to contribute this it must be a new page.
(https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ is for core FGs)
/help

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 4, 2021
@neolit123
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 4, 2021
@sftim
Copy link
Contributor Author

sftim commented Jul 5, 2021

Relevant to #28036 (generate feature gate lists from data) - for context only. No need for kubeadm to participate in the automation.

@sftim
Copy link
Contributor Author

sftim commented Jul 7, 2021

/priority important-longterm
People might want to try out alpha features; we should make it clear how they can, and follow docs conventions to explain that these are alpha.

(same for beta, if that applies)

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 7, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2021
@sftim
Copy link
Contributor Author

sftim commented Oct 5, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 5, 2021
@neolit123
Copy link
Member

/remove-help
/assign

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 1, 2022
@neolit123
Copy link
Member

#31687
merged.

/close

@k8s-ci-robot
Copy link
Contributor

@neolit123: Closing this issue.

In response to this:

#31687
merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants