Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use community images to list images to mirror #200

Merged
merged 3 commits into from
Mar 24, 2023
Merged

use community images to list images to mirror #200

merged 3 commits into from
Mar 24, 2023

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Mar 23, 2023 •
edited
Loading

following kubernetes-sigs/community-images#47 we can point to a general tool to dump the running images in a cluster*

*excluding at least pause. getting that info from a running cluster portably would be quite a trick.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2023
BenTheElder
BenTheElder commented Mar 23, 2023
View reviewed changes
docs/mirroring/README.md
help you identify Kubernetes Project image references to mirror like this:

```console
kubectl community-images --mirror
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting this tool inline because it's very very broadly useful to inventory images without much context on what the user is using. we should expand on this a bit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expanded a bit more in later commit

BenTheElder
BenTheElder commented Mar 23, 2023
View reviewed changes
docs/mirroring/README.md Outdated Show resolved Hide resolved
@BenTheElder
Copy link
Member Author

/hold
think the plugin needs fixing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2023
@BenTheElder
Copy link
Member Author

waiting for kubernetes-sigs/community-images#56

then will push the shell snippet here and cleanup

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2023
@BenTheElder
Copy link
Member Author

plugin is fixed
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2023
@dims
Copy link
Member

dims commented Mar 24, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1d8391e into kubernetes:main Mar 24, 2023
@BenTheElder BenTheElder deleted the community-images branch March 24, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hh hh Awaiting requested review from hh

@riaankleinhans riaankleinhans Awaiting requested review from riaankleinhans

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @dims @k8s-ci-robot