None driver #1173

aaron-prindle · 2017-02-23T20:03:35Z

This is a rough prototype of a minikube no-vm driver which moves all files into local locations and runs them as it does in the vm. All CLI commands are preserved. Currently the MINIKUBE_HOME directory needs to be configured and minikube start needs to be run as root.
To test:

export MINIKUBE_HOME=$HOME #REQUIRED TO PROPERLY CONFIGURE .kube and .minikube dir
export CHANGE_MINIKUBE_NONE_USER=true #REQUIRED TO CHANGE OWNERSHIP FROM root to the original $SUDO_USER
sudo /usr/local/bin/minikube start --vm-driver=none --use-vendored-driver
kubectl get po --all-namespaces
#The following commands are to show that the minikube CLI still works
minikube logs
minikube status
minikube ssh
minikube addons disable dashboard
minikube delete

Note: This requires requires docker installed on the host

dims · 2017-02-23T22:29:48Z

@aaron-prindle does it support the case where docker is not installed/configured? thanks!

aaron-prindle · 2017-02-23T22:31:36Z

@dims no, unfortunately this method would require having docker installed on the host machine

dims · 2017-02-23T22:35:58Z

Ack thanks i was scratching my head to see what i missed when i was poking at docker machine code before i ended up with #1152

justechn · 2017-03-27T23:36:16Z

I would love to see either this pull request or this one move forward. I think the idea is great and if it could work on a mac that would be even better.

codecov-io · 2017-04-17T18:55:43Z

Codecov Report

Merging #1173 into master will decrease coverage by 0.93%.
The diff coverage is 15.05%.

@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
- Coverage   40.45%   39.52%   -0.94%     
==========================================
  Files          50       50              
  Lines        2477     2548      +71     
==========================================
+ Hits         1002     1007       +5     
- Misses       1312     1375      +63     
- Partials      163      166       +3

Impacted Files	Coverage Δ
cmd/minikube/cmd/env.go	`64.39% <0%> (-3.61%)`	⬇️
pkg/minikube/machine/client_linux.go	`21.05% <0%> (-15.32%)`	⬇️
pkg/minikube/machine/client.go	`55.75% <0%> (-1.01%)`	⬇️
cmd/minikube/cmd/ssh.go	`10.52% <0%> (-6.15%)`	⬇️
cmd/minikube/cmd/mount.go	`5% <0%> (-0.2%)`	⬇️
cmd/minikube/cmd/status.go	`16.66% <0%> (ø)`	⬆️
cmd/minikube/cmd/start.go	`17.05% <0%> (-1.42%)`	⬇️
pkg/minikube/cluster/cluster_linux.go	`0% <0%> (ø)`	⬆️
pkg/minikube/cluster/commands.go	`57.89% <100%> (ø)`	⬆️
pkg/minikube/cluster/cluster.go	`45.96% <31.57%> (-2.19%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e4d45...f4a8ece. Read the comment docs.

aaron-prindle · 2017-04-17T23:53:45Z

@minikube-bot retest this please

aaron-prindle · 2017-04-19T21:32:05Z

@minikube-bot retest this please

omeid · 2017-05-20T13:16:12Z

Landing this would be great. The kvm vm eats way too much battery on my laptop :(

Is there anything pending?

dlorenc · 2017-05-20T15:06:01Z

Landing this would be great. The kvm vm eats way too much battery on my laptop :(

I think this is pretty close, but we still won't really recommend using it on a laptop. localkube/kubernetes assume quite a bit of freedom on the host machine.

omeid · 2017-05-21T04:23:57Z

Well, that is fair, at least I would be able to put on a compute instance somewhere then :)

dlorenc · 2017-05-26T17:39:32Z

pkg/minikube/assets/vm_assets.go

+	}
+
+	if os.Getenv("CHANGE_MINIKUBE_NONE_USER") != "" {
+		username := os.Getenv("SUDO_USER")


Should we bail out if this isn't set?

done, will continue with no additional chown if SUDO_USER is not set

dlorenc · 2017-05-26T17:39:50Z

cmd/minikube/cmd/start.go

+	if config.VMDriver == "none" {
+		fmt.Println(`===================
+WARNING: IT IS RECOMMENDED NOT TO RUN THE NONE DRIVER ON PERSONAL WORKSTATIONS
+	The 'none' driver will run an insecure kubernetes apiserver as root that may leave the host vulnerable to attacks


Could you clarify that these are CSRF attacks?

dlorenc · 2017-05-26T17:40:55Z

pkg/minikube/assets/vm_assets.go

+
+	if os.Getenv("CHANGE_MINIKUBE_NONE_USER") != "" {
+		username := os.Getenv("SUDO_USER")
+		command := fmt.Sprintf("/bin/chown %s %s", username, targetPath)


Can we use os.Chown and os.Chgrp instead of shelling out?

done. Also os.Chown appears to do the work of both chown and chgrp

aaron-prindle · 2017-05-26T17:51:53Z

Should also add precreate check for systemd
Edit: Done

aaron-prindle · 2017-05-26T21:47:33Z

@minikube-bot retest this please

dlorenc

Nice!

dlorenc · 2017-05-26T22:20:07Z

pkg/minikube/machine/drivers/none-driver.go

+limitations under the License.
+*/
+
+package drivers


We can do this in another PR later, but this should probably get moved into a subdirectory so we can have multiple drivers in here. Right now drivers.Driver will be this.

ernie · 2017-06-06T17:33:17Z

Hey folks. I arrived here via #99 (comment) and I'm wondering if it's still the intention to eventually use this to support running directly in Docker for Mac, or that's no longer the direction D4M users should be looking to go, since it looks like the existing --vm-driver=none implementation panics when not run inside a Linux vm.

dlorenc · 2017-06-06T17:35:17Z

This driver isn't intended to allow direct d4m use.

We're looking at a few better options for Mac integration, but the current thinking is still to use our own VM, but re-use the d4m tooling: #1543

ernie · 2017-06-06T17:36:29Z

@dlorenc thanks for the speedy response and the pointer!

googlebot added the cla: yes label Feb 23, 2017

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2017

dlorenc mentioned this pull request Feb 27, 2017

Compatible with Docker for Mac #99

Closed

aaron-prindle mentioned this pull request Mar 1, 2017

Speed up minikube start #1202

Closed

justechn mentioned this pull request Apr 11, 2017

Make xhyve default for OSX #270

Closed

aaron-prindle force-pushed the minikube-no-vm branch 10 times, most recently from 3f20952 to f859f5a Compare April 17, 2017 18:25

aaron-prindle force-pushed the minikube-no-vm branch 2 times, most recently from 0495b0d to 44f99fc Compare April 17, 2017 23:23

aaron-prindle force-pushed the minikube-no-vm branch from 44f99fc to 9453860 Compare April 18, 2017 16:06

aaron-prindle changed the title ~~WIP Prototype none driver~~ None driver Apr 18, 2017

aaron-prindle added the ready-for-review label Apr 18, 2017

aaron-prindle force-pushed the minikube-no-vm branch 3 times, most recently from c4b1ec3 to d7b44b1 Compare April 25, 2017 16:16

aaron-prindle force-pushed the minikube-no-vm branch 8 times, most recently from 5e37b36 to 9079795 Compare May 19, 2017 18:02

Added none driver

8861309

aaron-prindle force-pushed the minikube-no-vm branch from 9079795 to 9c0d967 Compare May 19, 2017 21:54

dlorenc reviewed May 26, 2017

View reviewed changes

aaron-prindle force-pushed the minikube-no-vm branch 6 times, most recently from a8f18a5 to ec583d2 Compare May 26, 2017 19:56

Additional none driver changes

f4a8ece

aaron-prindle force-pushed the minikube-no-vm branch from ec583d2 to f4a8ece Compare May 26, 2017 20:33

dlorenc approved these changes May 26, 2017

View reviewed changes

aaron-prindle merged commit a7c2ff3 into kubernetes:master May 26, 2017

ashutoshg mentioned this pull request Jun 8, 2017

Unable to start minikube with 'None driver' #1565

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

None driver #1173

None driver #1173

aaron-prindle commented Feb 23, 2017 •

edited

Loading

dims commented Feb 23, 2017

aaron-prindle commented Feb 23, 2017 •

edited

Loading

dims commented Feb 23, 2017

justechn commented Mar 27, 2017

codecov-io commented Apr 17, 2017 •

edited

Loading

aaron-prindle commented Apr 17, 2017

aaron-prindle commented Apr 19, 2017

omeid commented May 20, 2017

dlorenc commented May 20, 2017

omeid commented May 21, 2017 •

edited

Loading

dlorenc May 26, 2017

aaron-prindle May 26, 2017

dlorenc May 26, 2017

aaron-prindle May 26, 2017

dlorenc May 26, 2017

aaron-prindle May 26, 2017

aaron-prindle commented May 26, 2017 •

edited

Loading

aaron-prindle commented May 26, 2017

dlorenc left a comment

dlorenc May 26, 2017

ernie commented Jun 6, 2017

dlorenc commented Jun 6, 2017

ernie commented Jun 6, 2017

None driver #1173

None driver #1173

Conversation

aaron-prindle commented Feb 23, 2017 • edited Loading

dims commented Feb 23, 2017

aaron-prindle commented Feb 23, 2017 • edited Loading

dims commented Feb 23, 2017

justechn commented Mar 27, 2017

codecov-io commented Apr 17, 2017 • edited Loading

Codecov Report

aaron-prindle commented Apr 17, 2017

aaron-prindle commented Apr 19, 2017

omeid commented May 20, 2017

dlorenc commented May 20, 2017

omeid commented May 21, 2017 • edited Loading

dlorenc May 26, 2017

Choose a reason for hiding this comment

aaron-prindle May 26, 2017

Choose a reason for hiding this comment

dlorenc May 26, 2017

Choose a reason for hiding this comment

aaron-prindle May 26, 2017

Choose a reason for hiding this comment

dlorenc May 26, 2017

Choose a reason for hiding this comment

aaron-prindle May 26, 2017

Choose a reason for hiding this comment

aaron-prindle commented May 26, 2017 • edited Loading

aaron-prindle commented May 26, 2017

dlorenc left a comment

Choose a reason for hiding this comment

dlorenc May 26, 2017

Choose a reason for hiding this comment

ernie commented Jun 6, 2017

dlorenc commented Jun 6, 2017

ernie commented Jun 6, 2017

aaron-prindle commented Feb 23, 2017 •

edited

Loading

aaron-prindle commented Feb 23, 2017 •

edited

Loading

codecov-io commented Apr 17, 2017 •

edited

Loading

omeid commented May 21, 2017 •

edited

Loading

aaron-prindle commented May 26, 2017 •

edited

Loading