Added debugging of /usr/local/google/home/aprindle dir for integratio…

…n test errors

cmd/minikube/cmd/start.go

@@ -56,7 +56,7 @@ const (
 	hypervVirtualSwitch   = "hyperv-virtual-switch"
 	kvmNetwork            = "kvm-network"
 	keepContext           = "keep-context"
-	noMount               = "no-mount"
+	createMount           = "mount"
 	featureGates          = "feature-gates"
 	apiServerName         = "apiserver-name"
 	dnsDomain             = "dns-domain"
@@ -201,9 +201,11 @@ func runStart(cmd *cobra.Command, args []string) {
 		cmdUtil.MaybeReportErrorAndExit(err)
 	}
 
-	fmt.Printf("Setting up hostmount on %s...\n", viper.GetString(mountString))
 	// start 9p server mount
-	if !viper.GetBool(noMount) || cfg.GetMachineName() != constants.DefaultMachineName {
+	// if !viper.GetBool(noMount) || cfg.GetMachineName() != constants.DefaultMachineName {
+	if viper.GetBool(createMount) {
+		fmt.Printf("Setting up hostmount on %s...\n", viper.GetString(mountString))
+
 		path := os.Args[0]
 		mountDebugVal := 0
 		if glog.V(8) {
@@ -275,7 +277,7 @@ func calculateDiskSizeInMB(humanReadableDiskSize string) int {
 
 func init() {
 	startCmd.Flags().Bool(keepContext, constants.DefaultKeepContext, "This will keep the existing kubectl context and will create a minikube context.")
-	startCmd.Flags().Bool(noMount, constants.DefaultNoMount, "This will not start the mount daemon and automatically mount files into minikube")
+	startCmd.Flags().Bool(createMount, false, "This will start the mount daemon and automatically mount files into minikube")
 	startCmd.Flags().String(mountString, constants.DefaultMountDir+":"+constants.DefaultMountEndpoint, "The argument to pass the minikube mount command on start")
 	startCmd.Flags().String(isoURL, constants.DefaultIsoUrl, "Location of the minikube iso")
 	startCmd.Flags().String(vmDriver, constants.DefaultVMDriver, fmt.Sprintf("VM driver is one of: %v", constants.SupportedVMDrivers))

cmd/util/util.go

@@ -234,7 +234,7 @@ func GetPort() (string, error) {
 func KillMountProcess() error {
 	out, err := ioutil.ReadFile(filepath.Join(constants.GetMinipath(), constants.MountProcessFileName))
 	if err != nil {
-		return errors.Wrap(err, "error reading mount process from file")
+		return nil // no mount process to kill
 	}
 	pid, err := strconv.Atoi(string(out))
 	if err != nil {

hack/jenkins/common.sh

@@ -36,25 +36,48 @@ gsutil cp gs://minikube-builds/${MINIKUBE_LOCATION}/testdata/busybox-mount-test.
 chmod +x out/e2e-${OS_ARCH}
 chmod +x out/minikube-${OS_ARCH}
 
+#DEBUG
+echo "===================="
+ls $HOME
+echo "===================="
+
+
 MINIKUBE_WANTREPORTERRORPROMPT=False sudo ./out/minikube-${OS_ARCH} delete \
 || MINIKUBE_WANTREPORTERRORPROMPT=False ./out/minikube-${OS_ARCH} delete \
 || true
 sudo rm -rf $HOME/.minikube || true
+sudo rm -rf $HOME/.kube || true
+
 
 # See the default image
 ./out/minikube-${OS_ARCH} start -h | grep iso
 
+#DEBUG
+echo "===================="
+ls $HOME
+echo "===================="
+
 # Allow this to fail, we'll switch on the return code below.
 set +e
 ${SUDO_PREFIX}out/e2e-${OS_ARCH} -minikube-args="--vm-driver=${VM_DRIVER} --cpus=4 --v=100 ${EXTRA_BUILD_ARGS}" -test.v -test.timeout=30m -binary=out/minikube-${OS_ARCH}
 result=$?
 set -e
 
+#DEBUG
+echo "===================="
+ls $HOME
+echo "===================="
+
 MINIKUBE_WANTREPORTERRORPROMPT=False sudo ./out/minikube-${OS_ARCH} delete \
 || MINIKUBE_WANTREPORTERRORPROMPT=False ./out/minikube-${OS_ARCH} delete \
 || true
 sudo rm -rf $HOME/.minikube || true
+sudo rm -rf $HOME/.kube || true
 
+#DEBUG
+echo "===================="
+ls $HOME
+echo "===================="
 
 if [[ $result -eq 0 ]]; then
   status="success"

hack/jenkins/windows_integration_test_hyperv.ps1

@@ -21,7 +21,7 @@ gsutil.cmd cp -r gs://minikube-builds/$env:MINIKUBE_LOCATION/testdata .
 ./out/minikube-windows-amd64.exe delete
 Remove-Item -Recurse -Force C:\Users\jenkins\.minikube
 
-out/e2e-windows-amd64.exe --% -minikube-args="--vm-driver=hyperv --hyperv-virtual-switch=Minikube --cpus=4 $env:EXTRA_BUILD_ARGS --no-mount" -test.v -test.timeout=30m -binary=out/minikube-windows-amd64.exe
+out/e2e-windows-amd64.exe --% -minikube-args="--vm-driver=hyperv --hyperv-virtual-switch=Minikube --cpus=4 $env:EXTRA_BUILD_ARGS" -test.v -test.timeout=30m -binary=out/minikube-windows-amd64.exe
 
 $env:result=$lastexitcode
 # If the last exit code was 0->success, x>0->error

pkg/minikube/constants/constants.go

@@ -130,7 +130,6 @@ const (
 const (
 	DefaultUfsPort     = "5640"
 	DefaultUfsDebugLvl = 0
-	DefaultNoMount     = false
 )
 
 const IsMinikubeChildProcess = "IS_MINIKUBE_CHILD_PROCESS"

test/integration/persistence_test.go

@@ -95,7 +95,7 @@ func TestPersistence(t *testing.T) {
 		t.Fatalf("timed out while checking stopped status: %s", err)
 	}
 
-	minikubeRunner.RunCommand("start", true)
+	minikubeRunner.Start()
 	minikubeRunner.CheckStatus(state.Running.String())
 
 	if err := commonutil.RetryAfter(5, checkPod, 3*time.Second); err != nil {