-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv6 support for kindnet #17190
Add IPv6 support for kindnet #17190
Conversation
Skipping CI for Draft Pull Request. |
/test ? |
/test pull-kops-e2e-cni-kindnet-ipv6 |
/test pull-kops-e2e-cni-kindnet-ipv6 |
test failing are related to statefulset that can not be scheduled
all the other 933 tests are passing the ebs-csi-controller seems to require some permissions I0108 21:03:04.353521 1 controller.go:843] CreateVolume failed, supports topology = true, node selected true => may reschedule = true => state = Finished: rpc error: code = Internal desc = Could not create volume "pvc-be11211d-1a70-4573-931a-1f1da03eff77": could not create volume in EC2: operation error EC2: CreateVolume, get identity: get credentials: failed to refresh cached credentials, failed to retrieve credentials, operation error STS: AssumeRoleWithWebIdentity, failed to get rate limit token, retry quota exceeded, 0 available, 5 requested |
Pretty odd, let's retry first 🙂 |
/test pull-kops-e2e-cni-kindnet-ipv6 |
still the same problem
yeah, it may be to the masquerading, there is an EOF in the request |
the kindnet in the same node logs these messages
that is an amazon ip https://urlscan.io/ip/52.94.181.70 in the docs https://kops.sigs.k8s.io/topology/#private-subnet
so maybe to access that Service you need to use the provided nat64 by aws and is not available from the instances? |
pkg/model/components/kindnet.go
Outdated
if c.Masquerade == nil { | ||
c.Masquerade = &kops.KindnetMasqueradeSpec{ | ||
Enabled: fi.PtrTo(true), | ||
if clusterSpec.IsIPv6Only() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to disable NAT64 in Kindnet If is AWS and if is IPv6 only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... or disable NAT64 gateway and allow IPv4 connectivity from the instance , I just throw the options, no strong opinion
ok, talked offline with @hakman Kops has a NAT64 gateway setup in aws However, my feedback from users is that they want to avoid NAT gateways at all cost, they are expensive and causes problems, kindnet offers an alternative to this setup if the instance has also IPv4 connectivity by enabling NAT64, right now it fails because the instance does not have IPv4 connectivity |
/test pull-kops-e2e-cni-kindnet-ipv6 |
fantastic
|
d027b8e
to
8ae9bae
Compare
/test pull-kops-e2e-cni-kindnet |
/retest |
/lgtm Thanks |
Thanks for all the help getting IPv6 to work, @aojea! 🙂 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks you all for doing this :) |
/cc @justinsb @rifelpet @aojea