-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-25373: Message is not a required field in the CRDs #2019
OCPBUGS-25373: Message is not a required field in the CRDs #2019
Conversation
Remove `message` from the required list of fields.
Hi @yuumasato. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuumasato The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2019 +/- ##
=======================================
Coverage 47.32% 47.32%
=======================================
Files 77 77
Lines 7352 7352
=======================================
Hits 3479 3479
Misses 3742 3742
Partials 131 131 |
@yuumasato: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold for test |
@@ -123,7 +123,6 @@ spec: | |||
type: string | |||
required: | |||
- lastTransitionTime | |||
- message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those fields are auto-generated. I think we have to change the go code to fix that up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to override the "+required"?
https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1#Condition
I'm afraid the fix might mean reverting to using self defined Condition
.
I'm closing this in favor of #2023 |
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
message
from the required list of CRD fieldsWhich issue(s) this PR fixes:
None
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?