Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Go to 1.23.4 #1580

Merged
merged 3 commits into from
Jan 10, 2025
Merged

chore: update Go to 1.23.4 #1580

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bbf36f
chore: update Go to 1.23.2
unguiculus Oct 11, 2024
6e792b5
chore: update Go to 1.23.3
unguiculus Nov 15, 2024
2f51692
chore: update Go to 1.23.4
unguiculus Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Update the base image in Makefile when updating golang version. This has to
# be pre-pulled in order to work on GCB.
ARG ARCH
FROM golang:1.23.1 as build
FROM golang:1.23.3 as build

WORKDIR /go/src/sigs.k8s.io/metrics-server
COPY go.mod .
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ CONTAINER_ARCH_TARGETS=$(addprefix container-,$(ALL_ARCHITECTURES))
container:
# Pull base image explicitly. Keep in sync with Dockerfile, otherwise
# GCB builds will start failing.
docker pull golang:1.23.1
docker pull golang:1.23.3
docker build -t $(REGISTRY)/metrics-server-$(ARCH):$(CHECKSUM) --build-arg ARCH=$(ARCH) --build-arg GIT_TAG=$(GIT_TAG) --build-arg GIT_COMMIT=$(GIT_COMMIT) .

.PHONY: container-all
Expand Down
4 changes: 1 addition & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module sigs.k8s.io/metrics-server

go 1.23.0

toolchain go1.23.1
unguiculus marked this conversation as resolved.
Show resolved Hide resolved
go 1.23.3

require (
github.com/google/go-cmp v0.6.0
Expand Down
4 changes: 1 addition & 3 deletions scripts/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module sigs.k8s.io/metrics-server/scripts

go 1.23.0

toolchain go1.23.1
go 1.23.3

require (
github.com/google/addlicense v1.1.1
Expand Down