-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(chart): Update addon-resizer
version
#1504
Conversation
|
Welcome @jimmy-ungerman! |
Hi @jimmy-ungerman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@s-urbaniak hoping I could get a quick review on this |
/assign @stevehipwell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jimmy-ungerman. Could you please also add an entry to the chart CHANGELOG for this change and squash your commits?
@stevehipwell Done! |
Thanks @jimmy-ungerman. /ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmy-ungerman, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stevehipwell is there a pipeline somewhere that will run and update the chart version in chart.yaml? It's still reflecting the old 3.12.1 |
@jimmy-ungerman the chart release process would need following. Is there a reason why this change needs to be released now? |
@stevehipwell I just think it's best practice to increment the chart version anytime a change occurs inside the chart. |
@jimmy-ungerman you can request a chart release, but it requires time and effort so it's not something that just happens. |
What this PR does / why we need it:
Updates the addon-resizer image in the Helm Chart to match the most recent addon-resizer release here