Skip to content

Commit

Permalink
Merge pull request #1580 from unguiculus/go-1.23.2
Browse files Browse the repository at this point in the history
chore: update Go to 1.23.4
  • Loading branch information
k8s-ci-robot authored Jan 10, 2025
2 parents ddbf341 + 2f51692 commit 0dcee07
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Update the base image in Makefile when updating golang version. This has to
# be pre-pulled in order to work on GCB.
ARG ARCH
FROM golang:1.23.1 as build
FROM golang:1.23.4 as build

WORKDIR /go/src/sigs.k8s.io/metrics-server
COPY go.mod .
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ CONTAINER_ARCH_TARGETS=$(addprefix container-,$(ALL_ARCHITECTURES))
container:
# Pull base image explicitly. Keep in sync with Dockerfile, otherwise
# GCB builds will start failing.
docker pull golang:1.23.1
docker pull golang:1.23.4
docker build -t $(REGISTRY)/metrics-server-$(ARCH):$(CHECKSUM) --build-arg ARCH=$(ARCH) --build-arg GIT_TAG=$(GIT_TAG) --build-arg GIT_COMMIT=$(GIT_COMMIT) .

.PHONY: container-all
Expand Down
4 changes: 1 addition & 3 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module sigs.k8s.io/metrics-server

go 1.23.0

toolchain go1.23.1
go 1.23.4

require (
github.com/google/go-cmp v0.6.0
Expand Down
4 changes: 1 addition & 3 deletions scripts/go.mod
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module sigs.k8s.io/metrics-server/scripts

go 1.23.0

toolchain go1.23.1
go 1.23.4

require (
github.com/google/addlicense v1.1.1
Expand Down

0 comments on commit 0dcee07

Please sign in to comment.