Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchTransformer does not support array literal #5806

Open
alchemistake opened this issue Nov 21, 2024 · 2 comments
Open

PatchTransformer does not support array literal #5806

alchemistake opened this issue Nov 21, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@alchemistake
Copy link

alchemistake commented Nov 21, 2024

What happened?

I hope I'm doing something wrong than there is a problem with Kustomize

I'm using this file

apiVersion: builtin
kind: PatchTransformer
metadata:
  name: example
target:
  kind: Deployment
patch: |
  - op: add
    path: /spec/template/spec/volumes/-
    value:
      - name: my_example_volume
        emptyDir: {}
  - op: add
    path: /spec/template/spec/containers/0/env/-
    value:
      - name: EXAMPLE_DIR
        value: /etc/wow_example
  - op: add
    path: /spec/template/spec/containers/0/volumeMounts/-
    value:
      - name: my_example_volume-multiproc-dir
        mountPath: /etc/wow_example

and I'm getting this error

add operation does not apply: doc is missing path: "/spec/template/spec/volumes/-": missing value

What did you expect to happen?

I was expecting the volume and env vars in the transformer would be appended to the deployment.

How can we reproduce it (as minimally and precisely as possible)?

# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- resources.yaml
tranformers:
- tranformer.yaml
# transformer.yaml
apiVersion: builtin
kind: PatchTransformer
metadata:
  name: example
target:
  kind: Deployment
patch: |
  - op: add
    path: /spec/template/spec/containers/0/env/-
    value:
      - name: EXAMPLE_DIR
        value: /etc/wow_example
# resources.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  replicas: 3
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: nginx:1.14.2
        ports:
        - containerPort: 80
       - env:
         - name: hello
           value: world

Expected output

apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  replicas: 3
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: nginx:1.14.2
        ports:
        - containerPort: 80
       - env:
         - name: hello
           value: world
         - name: EXAMPLE_DIR
            value: /etc/wow_example

Actual output

Errors out because of path.

Kustomize version

v5.5.0

Operating system

MacOS

@alchemistake alchemistake added the kind/bug Categorizes issue or PR as related to a bug. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants