Different behavior in adding the Block Chomping Indicator to strings

[duritong]

What happened?

given the following structure:

$ cat configmap.yaml
kind: ConfigMap
apiVersion: v1
metadata:
  name: test
data:
  string: ''
---
kind: ConfigMap
apiVersion: v1
metadata:
  name: test2
data:
  string: ''
$ cat kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- configmap.yaml

patches:
- target:
    kind: ConfigMap
    version: v1
    name: test
  patch: |
    - op: replace
      path: /data/string
      value: |+
        this is
        a multiline string

        that should have an empty line at the end

- target:
    kind: ConfigMap
    version: v1
    name: test2
  patch: |
    - op: replace
      value: |+
        this is
        a multiline string

        that should have an empty line at the end

      path: /data/string

We get the following output:

$ kustomize version
v5.5.0
$ kustomize build
apiVersion: v1
data:
  string: |-
    this is
    a multiline string

    that should have an empty line at the end
kind: ConfigMap
metadata:
  name: test
---
apiVersion: v1
data:
  string: |+
    this is
    a multiline string

    that should have an empty line at the end

kind: ConfigMap
metadata:
  name: test2

Although it seems we do have two times the same patch that we do get different results depending on whether we do have something after the string, that is still part of the path or not.

What did you expect to happen?

Both patches should produce the same output.

How can we reproduce it (as minimally and precisely as possible)?

# configmap.yaml
kind: ConfigMap
apiVersion: v1
metadata:
  name: test
data:
  string: ''
---
kind: ConfigMap
apiVersion: v1
metadata:
  name: test2
data:
  string: ''

# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- configmap.yaml

patches:
- target:
    kind: ConfigMap
    version: v1
    name: test
  patch: |
    - op: replace
      path: /data/string
      value: |+
        this is
        a multiline string

        that should have an empty line at the end

- target:
    kind: ConfigMap
    version: v1
    name: test2
  patch: |
    - op: replace
      value: |+
        this is
        a multiline string

        that should have an empty line at the end

      path: /data/string

Expected output

apiVersion: v1
data:
  string: |+
    this is
    a multiline string

    that should have an empty line at the end

kind: ConfigMap
metadata:
  name: test
---
apiVersion: v1
data:
  string: |+
    this is
    a multiline string

    that should have an empty line at the end

kind: ConfigMap
metadata:
  name: test2

Actual output

apiVersion: v1
data:
  string: |-
    this is
    a multiline string

    that should have an empty line at the end
kind: ConfigMap
metadata:
  name: test
---
apiVersion: v1
data:
  string: |+
    this is
    a multiline string

    that should have an empty line at the end

kind: ConfigMap
metadata:
  name: test2

Kustomize version

5.5.0

Operating system

Linux

[k8s-ci-robot]

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten