-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/dependabot updates #3561
ci/dependabot updates #3561
Conversation
/hold we can't just upgrade to 1.22 because of the toolchain changes there's a pending PR in #3335 that resolves those |
.go-version
Outdated
@@ -1 +1 @@ | |||
1.20.13 | |||
1.22.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will actually cause us to use go 1.16 because of toolchains :-)
can you rebase this to remove the merge commit? it will make bisecting less confusing. we could do squash merging, except this PR has multiple unrelated changes |
that was weird, i swear i did a rebase this morning, but i can be wrong, missing coffee lol but rebase is done now :) |
thanks. Seems we shouldn't switch to 1.22 yet: https://github.com/opencontainers/runc/pull/4240/files https://kubernetes.slack.com/archives/CHGFYJVAN/p1712086885304549 |
we can hold or close this pr |
sigh: #3335 (comment) maybe we can merge the rest without the go bump? we may have to roll back go temporarily even for 1.21 |
ok will remove the go bump |
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@BenTheElder PTAL |
cc @aojea |
we already setup go from the makefile Line 37 in 915b13a
Lines 19 to 40 in 915b13a
I assume this does not harm and saves some time /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/assign @aojea @BenTheElder