Change ingress fetching to be isolated per provider #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
LiorLieberman
temporarily deployed
to
release
GitHub Actions
Inactive
k8s-ci-robot
added
the
size/L
|
/label tide/merge-method-merge |
k8s-ci-robot
added
the
tide/merge-method-merge
LiorLieberman
temporarily deployed
to
release
GitHub Actions
Inactive
2 tasks
Also added issue numbers for TODOs
LiorLieberman
temporarily deployed
to
release
GitHub Actions
Inactive
k8s-ci-robot
added
size/XL
|
|
||
| for _, f := range unstructuredObjects { | ||
| if !f.GroupVersionKind().Empty() && f.GroupVersionKind().Kind == "Ingress" { | ||
| var i networkingv1.Ingress |
There was a problem hiding this comment.
optional: i -> ingress
Usually i is associated with the iteration variable for index, ingress has more readability IMO.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold to ensure it's not automerged and there's another lgtm or approve |
k8s-ci-robot
added
the
do-not-merge/hold
|
I too fell for it before @dpasiukevich 😅 |
levikobi
reviewed
Jan 2, 2024
|
resolved all the comments here 835e917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently we fetch all the ingresses in the main package and we pass them to all the providers.
This is not only redundant (as every provider only cares about its own ingresses) but also creates some bugs. (#109)
This also increases consistency as we already fetch CRDs at the provider level and store them in a local storage.
Note: This PR is likely to yield some more issues and TODOs that wont be addressed in this PR.
For example changing
ToGatewayAPIinterface function signature that wont needi2gw.InputResourcesanymore.Another thing would be to revisit
i2gw.InputResourcesstruct and check if we need it or we will change it to just a list of Ingresses as it is the only things it holds now.I structured the commits to ease the review so you could review each commit independently
Which issue(s) this PR fixes:
Fixes #109
Does this PR introduce a user-facing change?: