Redefined Gateway API Types

[danehans]

Currently, gateway-api-inference-extension defines API types that exist in Gateway API. For example:

// PoolObjectReference identifies an API object within the namespace of the
// referrer.
type PoolObjectReference struct {
	Group string `json:"group,omitempty"`

	Kind string `json:"kind,omitempty"`

	Name string `json:"name,omitempty"`
}

Gateway API defines custom alias types for Group, Kind, and Name. For consistency, should these types be imported and used instead of redefining them as opaque strings? For example:

import gwv1 "sigs.k8s.io/gateway-api/apis/v1"

// PoolObjectReference identifies an API object within the namespace of the
// referrer.
type PoolObjectReference struct {
	Group gwv1.Group `json:"group,omitempty"`
	Kind  gwv1.Kind `json:"kind,omitempty"`
	Name  gwv1.ObjectName `json:"name,omitempty"`
}

[danehans]

cc: @robscott

[robscott]

Good catch, thanks @danehans! The goal here was to add some defaults here so 99% of users would only need to specify a name, similar to how BackendRef works in Gateway API. Those have been added now, so hopefully it makes a bit more sense:

gateway-api-inference-extension/api/v1alpha1/inferencemodel_types.go

Lines 71 to 89 in 60bab3a

	// PoolObjectReference identifies an API object within the namespace of the
	// referrer.
	type PoolObjectReference struct {
	// Group is the group of the referent.
	//
	// +optional
	// +kubebuilder:default="inference.networking.x-k8s.io"
	// +kubebuilder:validation:MaxLength=253
	// +kubebuilder:validation:Pattern=`^$|^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`
	Group string `json:"group,omitempty"`
	// Kind is kind of the referent. For example "InferencePool".
	//
	// +optional
	// +kubebuilder:default="InferencePool"
	// +kubebuilder:validation:MinLength=1
	// +kubebuilder:validation:MaxLength=63
	// +kubebuilder:validation:Pattern=`^[a-zA-Z]([-a-zA-Z0-9]*[a-zA-Z0-9])?$`
	Kind string `json:"kind,omitempty"`