fix: imagePullPolicy was ignored

[missedone]

Purpose of this PR

Close #2221

Proposed changes:

• return the image option args properly

Change Category

Indicate the type of change by marking the applicable boxes:

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Checklist

Before submitting your PR, please review the following:

• I have conducted a self-review of my own code.
• I have updated documentation accordingly.
• I have added tests that prove my changes are effective or that my feature works.
• Existing unit tests pass locally with my changes.

Additional Notes

[missedone]

better to enable the submission test and add the test case to perform regression test in the future

https://github.com/kubeflow/spark-operator/blob/release-2.0/internal/controller/sparkapplication/submission_test.go

[missedone]

updated the PR to better handle various cases, especially when spec.image is not set, but spark.kubernetes.driver.container.image and/or spark.kubernetes.executor.container.image is set, in this case, the spec.imagePullPolicy should be applied to driver and/or executor image as well

[ChenYi015]

@missedone Thanks for reporting and fixing this issue. Could you change the target branch of this PR to the master branch? We will cherry pick this PR when we do the next release.

[missedone]

@ChenYi015 , sure, PR is updated to target master branch

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ChenYi015]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ChenYi015]

/lgtm