New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podmonitor expects to be used only in apply format. #2461

Open

BenCoughlan15 opened this issue Mar 10, 2025 · 0 comments

BenCoughlan15 commented Mar 10, 2025

spark-operator/charts/spark-operator-chart/templates/prometheus/podmonitor.yaml

Line 21 in 3128c7f

    
           {{- if not (.Capabilities.APIVersions.Has "monitoring.coreos.com/v1/PodMonitor") }}

This line means it's doing a lookup against the cluster every time I try to template the chart.

in CI, I template, diff, run kubeconform, etc against the yaml before allowing ArgoCD to take over.

This is to prevent unintended changes, and works as a useful quality gate.

Do you think we could comment this out, or make it optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment