fix #2221: imagePullPolicy was ignored

Signed-off-by: xuqingtan <missedone@gmail.com>
kubeflow · Oct 6, 2024 · 34eb7ea · 34eb7ea
1 parent 94cdc52
commit 34eb7ea
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/controller/sparkapplication/submission.go b/internal/controller/sparkapplication/submission.go
@@ -206,15 +206,15 @@ func imageOption(app *v1beta2.SparkApplication) ([]string, error) {
 	)
 
 	if app.Spec.ImagePullPolicy == nil || *app.Spec.ImagePullPolicy == "" {
-		return nil, nil
+		return args, nil
 	}
 	args = append(args,
 		"--conf",
 		fmt.Sprintf("%s=%s", common.SparkKubernetesContainerImagePullPolicy, *app.Spec.ImagePullPolicy),
 	)
 
 	if len(app.Spec.ImagePullSecrets) == 0 {
-		return nil, nil
+		return args, nil
 	}
 	secrets := strings.Join(app.Spec.ImagePullSecrets, ",")
 	args = append(args,