-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): iterator and sub-DAG basic support #6985
Conversation
/hold |
I need to first upgrade test cluster mlmd version. |
c0c23be
to
5661677
Compare
'inputs': { | ||
'artifacts': [], | ||
'parameters': {} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed all the empty structs for more concise comparison
v2/Makefile
Outdated
.PHONY: test-update | ||
test-update: mlmd | ||
# Updating compiled argo YAML golden files... | ||
go test ./... -- --update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set up a new make target to easily update v2 compiler golden compiled results
/unhold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test all |
* chore(samples): add loop_output_v2 sample * feat(v2): iterator support * refactor v2 backend compiler tests to golden files * fix unit tests * test(v2): verify loop_output_test MLMD data * clean up * fix * fix2 * fix
Description of your changes:
Part of #6160
This adds basic sub-DAG and iterator support.
The following advanced features will be supported separately:
Checklist: