-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: dockerhub introduces a stricter rate limit #11664
base: master
Are you sure you want to change the base?
Conversation
… is also EOL soon in October 2025 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… is also EOL soon in October 2025 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
… is also EOL soon in October 2025 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@@ -11,7 +11,7 @@ spec: | |||
spec: | |||
containers: | |||
- name: profile-controller | |||
image: python:3.9 | |||
image: public.ecr.aws/docker/library/python:3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one here is the most important change for end users. I am running this for a long time on 3.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliusvonkohout @HumairAK, we currently support versions 3.9 to 3.12. If we're dropping support for 3.9, I think we should replace it with 3.10 instead of 3.12. If we use 3.12, we may end up using some feature that still doesn't exist in 3.10.
Alright, let me replace 3.12 with 3.10 |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
It seems you have a bug as soon as the python version has 3 digits such as 3.10 instead of 3.9 |
@juliusvonkohout you need to set |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
See also kubeflow/manifests#3010 (comment) @hbelmiro @HumairAK and 3.9 is EOL in October so I upgraded it.