Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: dockerhub introduces a stricter rate limit #11664

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

juliusvonkohout
Copy link
Member

See also kubeflow/manifests#3010 (comment) @hbelmiro @HumairAK and 3.9 is EOL in October so I upgraded it.

… is also EOL soon in October 2025

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… is also EOL soon in October 2025

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
… is also EOL soon in October 2025

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@@ -11,7 +11,7 @@ spec:
spec:
containers:
- name: profile-controller
image: python:3.9
image: public.ecr.aws/docker/library/python:3.12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one here is the most important change for end users. I am running this for a long time on 3.12

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusvonkohout @HumairAK, we currently support versions 3.9 to 3.12. If we're dropping support for 3.9, I think we should replace it with 3.10 instead of 3.12. If we use 3.12, we may end up using some feature that still doesn't exist in 3.10.

@juliusvonkohout
Copy link
Member Author

@juliusvonkohout @HumairAK, we currently support versions 3.9 to 3.12. If we're dropping support for 3.9, I think we should replace it with 3.10 instead of 3.12. If we use 3.12, we may end up using some feature that still doesn't exist in 3.10.

Alright, let me replace 3.12 with 3.10

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member Author

It seems you have a bug as soon as the python version has 3 digits such as 3.10 instead of 3.9

@hbelmiro
Copy link
Contributor

It seems you have a bug as soon as the python version has 3 digits such as 3.10 instead of 3.9

@juliusvonkohout you need to set "3.10" (string) instead of 3.10 (number).

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants