Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifests): Upgrading metacontroller to v4.11.22 #11656

Merged

Conversation

tarekabouzeid
Copy link
Member

@tarekabouzeid tarekabouzeid commented Feb 19, 2025

Description of your changes:
Upgrading metacontroller manifests to v4.11.22 according to this PR in Kubeflow manifests and this issue.

This entails changing metacontroller type from composite to decorator, as since metacontroller v3, it's not supported to watch namespaces which is preventing creating necessary K8s objects for KFP multi tenancy.

cc @juliusvonkohout @hbelmiro @HumairAK

Checklist:

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
@juliusvonkohout
Copy link
Member

Thank you very much. This should go at least into the kfp 2.5.0 release for kubeflow 1.10.1.

@@ -5,7 +5,10 @@ metadata:
rules:
- apiGroups: [""]
resources: ["namespaces"]
verbs: ["get", "list", "watch"]
verbs: ["get", "list", "watch", "update"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the update namespace permission? If yes please in both PRs. If we strictly need that permission that is also fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it is needed by Decorator Controller, when i remove it i get the below error in metacontroller pod

{
    "level": "error",
    "ts": "2025-02-21T19:26:35Z",
    "msg": "Unhandled Error",
    "logger": "UnhandledError",
    "error": "failed to sync kubeflow-pipelines-profile-controller 'v1:Namespace::kubeflow-user-example-com': can't update Namespace /kubeflow-user-example-com: namespaces \"kubeflow-user-example-com\" is forbidden: User \"system:serviceaccount:kubeflow:meta-controller-service\" cannot update resource \"namespaces\" in API group \"\" in the namespace \"kubeflow-user-example-com\"",
    "stacktrace": "metacontroller/pkg/controller/decorator.(*decoratorController).processNextWorkItem\n\t/home/runner/work/metacontroller/metacontroller/pkg/controller/decorator/controller.go:320\nmetacontroller/pkg/controller/decorator.(*decoratorController).worker\n\t/home/runner/work/metacontroller/metacontroller/pkg/controller/decorator/controller.go:308\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.32.0/pkg/util/wait/backoff.go:226\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.32.0/pkg/util/wait/backoff.go:227\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.32.0/pkg/util/wait/backoff.go:204\nk8s.io/apimachinery/pkg/util/wait.Until\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.32.0/pkg/util/wait/backoff.go:161\nmetacontroller/pkg/controller/decorator.(*decoratorController).Start.func1.1\n\t/home/runner/work/metacontroller/metacontroller/pkg/controller/decorator/controller.go:282"
}

@juliusvonkohout
Copy link
Member

Except for #11656 (comment) it is a
/lgtm

@juliusvonkohout
Copy link
Member

Then @hbelmiro @HumairAK please merge this to master such that we have it in KFP 2.5.0

@HumairAK
Copy link
Collaborator

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ebaaf75 into kubeflow:master Feb 23, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants