Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(frontend): Upgrade Express to version 5 Fixes #11595 #11655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(frontend): Upgrade Express to version 5 Fixes #11595 #11655

wants to merge 1 commit into from

Conversation

fyzanshaik
Copy link

  • Update Express from v4 to v5
  • Update related type definitions
  • Prepare for future maintenance

Description of your changes:

Checklist:

Description

Upgrade Express from version 4 to version 5 in the Kubeflow Pipelines frontend server component.

Changes

  • Updated Express dependency to the latest major version (v5)
  • Updated @types/express to match the new version
  • Minimal changes to ensure compatibility with existing server configuration

Motivation

  • Stay current with the latest Express framework
  • Potential performance and security improvements
  • Prepare for future maintenance and updates

Potential Impacts

  • No expected breaking changes for the frontend server
  • Recommended to run thorough testing to verify complete compatibility

Testing

  • Verified package installation
  • Recommended to run comprehensive test suite to ensure no regressions

Additional Notes

@fyzanshaik
chore(frontend): Upgrade Express to version 5 Fixes kubeflow#11595
dbbe419 
- Update Express from v4 to v5
- Update related type definitions
- Prepare for future maintenance

Signed-off-by: Faizan Shaik <fyzanshaik.work@gmail.com>
Signed-off-by: fyzanshaik <fyzan.shaik@gmail.com>
@google-oss-prow Google OSS Prow
Copy link

Hi @fyzanshaik. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@fyzanshaik
Copy link
Author

Fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HumairAK HumairAK Awaiting requested review from HumairAK

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees
No one assigned
Labels
ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fyzanshaik @hbelmiro