-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Add Input Parameter support for configmap, secrets, node selectors, tolerations, pull secrets #11621
base: master
Are you sure you want to change the base?
Conversation
c9c3858
to
61860db
Compare
cc @chensun please review the proto changes here when you get the chance so we are aligned here, as some fields are also being deprecated |
Please also note that this is a more generic implementation of how we were handling inputs already for pvc mounts in the k8s platform spec here, but extended to various other fields One thing also worth noting is that we probably don't need the entire |
|
The tests failures are a redherring, it's because of the compiled proto packages that are not utilizing the new code |
61860db
to
e45ba7a
Compare
0bd1120
to
e93d731
Compare
9f1bdb5
to
9e3efbd
Compare
9e3efbd
to
745691f
Compare
6115f6d
to
ae0f759
Compare
This change adds the necessary proto changes to accomodate parameterized input for various k8s platform fields: secrets, configmaps, node selectors, tolerations, and image pull secrets. It copies the input param pec from the pipeline spec, we can't import these due to circular dependencies. The format follows the standard that pvc_mount employs, but generalizes it further. Old fields are marked deprecated in favor of the new fields. Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
ae0f759
to
d61886a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d61886a
to
06de2bc
Compare
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
06de2bc
to
5106646
Compare
Description of your changes:
Related:
set_env_variable
compatible with the channels [KFP V2] #10111These will be marked resolved once the backend & sdk changes are merged after this.
This change provides proto api support for the following kubernetes platform
fields:
Checklist: