(test) : Collect and upload logs when test fails for k8s #11618
Conversation
|
Hi @chahatsagarmain. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
@chahatsagarmain you missed .github/workflows/upgrade-test.yml.
Also, could you intentionally introduce an error and create a PR to your fork so we can see the result? You can use a new branch for that to avoid affecting this PR.
chahatsagarmain
force-pushed
the
log-fail-real
branch
5 times, most recently
from
b4fb913 to
6db5809
Compare
chahatsagarmain
force-pushed
the
log-fail-real
branch
from
24e8716 to
0c31627
Compare
chahatsagarmain
force-pushed
the
log-fail-real
branch
from
0c31627 to
f027c1a
Compare
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> fix: Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> add log upload functionality Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> changes Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> test Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> update permission Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> update permission Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> fail test Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> remove exit Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> update permission Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> update Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> update Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> add condition Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> test Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> test Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> Remove exit Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> test Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> fix pod name Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> Remove exit Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> refactor Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> test Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> remove exit Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
chahatsagarmain
force-pushed
the
log-fail-real
branch
from
b9cd8ac to
f91c63f
Compare
|
@hbelmiro Its now able to output the logs in collect failed logs step . One of the tests (KFP samples) seems to fail and its outputing the logs in the step . |
There was a problem hiding this comment.
Awesome! Looks great now.
Thank you @chahatsagarmain.
/lgtm
/ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) fix: add log upload functionality changes test update permission update permission fail test remove exit update permission update update add condition test test Remove exit test fix pod name Remove exit refactor test remove exit Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> (cherry picked from commit 8ca7ec1)
Description of your changes:
Checklist: