fix: Incorrect typing in samples/cores/loop_parallism and fixing loop…

…_parameter examples (#11062) * Fixing incorrect typing in loop_parallism example Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com> * Fixing samples/core/loop_parameter example Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com> --------- Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com> Co-authored-by: Oswaldo Gomez <oswaldo.gomez@roche.com>
kubeflow · Aug 2, 2024 · 1612dac · 1612dac
1 parent ff4e918
commit 1612dac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/samples/core/loop_parallelism/loop_parallelism.py b/samples/core/loop_parallelism/loop_parallelism.py
@@ -15,7 +15,7 @@
 from kfp import compiler, dsl
 
 @dsl.component()
-def print_op(s: str):
+def print_op(s: int):
     print(s)
 
 @dsl.pipeline(name='my-pipeline')

diff --git a/samples/core/loop_parameter/loop_parameter.py b/samples/core/loop_parameter/loop_parameter.py
@@ -14,10 +14,8 @@ def concat_op(a: str, b: str) -> str:
 
 
 @dsl.component
-def generate_op() -> str:
-    import json
-    return json.dumps([{'a': i, 'b': i * 10} for i in range(1, 5)])
-
+def generate_op() -> list:
+    return [{'a': i, 'b': i * 10} for i in range(1, 5)]
 
 @dsl.pipeline(name='pipeline-with-loop-parameter')
 def my_pipeline(