Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize kubeflow model registry manifests v0.2.14 #2998

Conversation

tarilabs
Copy link
Member

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

  1. make script BSD/MacOSX compatible (e1dcefe)
  2. update the manifests

📦 Dependencies

none related

🐛 Related Issues

none related

✅ Contributor Checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Copy link
Member

@juliusvonkohout juliusvonkohout Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering a bit why you split the securitycontext here compared to your other deployments, but in general its good.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @juliusvonkohout, can these be combined? I don't think they can be (except for perhaps a YAML anchor), but I don't especially like the duplication between them, so if you have a way I'd love to use it.

I see that PodSecurityContext settings are inherited by containers, but it doesn't include allowPrivledgeEscalation or capabilities. As far as I can tell, the only way to set those is on each container (SecurityContext), and this pod has two containers.

I could have moved runAsUser and runAsGroup up to the pod level, but it was only needed on the MLMD container, since the model registry image already used a non-root user.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Feb 17, 2025

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout self-assigned this Feb 17, 2025
@juliusvonkohout
Copy link
Member

@tarilabs just check the comment and maybe follow up

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 17, 2025
@google-oss-prow google-oss-prow bot merged commit 8401db5 into kubeflow:master Feb 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants