-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize kubeflow model registry manifests v0.2.14 #2998
Synchronize kubeflow model registry manifests v0.2.14 #2998
Conversation
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering a bit why you split the securitycontext here compared to your other deployments, but in general its good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @juliusvonkohout, can these be combined? I don't think they can be (except for perhaps a YAML anchor), but I don't especially like the duplication between them, so if you have a way I'd love to use it.
I see that PodSecurityContext
settings are inherited by containers, but it doesn't include allowPrivledgeEscalation
or capabilities
. As far as I can tell, the only way to set those is on each container (SecurityContext
), and this pod has two containers.
I could have moved runAsUser
and runAsGroup
up to the pod level, but it was only needed on the MLMD container, since the model registry image already used a non-root user.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tarilabs just check the comment and maybe follow up /lgtm |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
📦 Dependencies
none related
🐛 Related Issues
none related
✅ Contributor Checklist