-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix warnings after kustomize build in contrib #2992
fix warnings after kustomize build in contrib #2992
Conversation
a107586
to
3b45a3b
Compare
…mization.yaml Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
You also need to raise it in the upstream repository see https://github.com/kubeflow/manifests/blob/master/hack/synchronize-kserve-web-app-manifests.sh |
thank you - i'll do so and make sure the output stays the same. |
|
thanks for your help - the |
Here is the upstream file https://github.com/kserve/models-web-app/blob/master/config/base/kustomization.yaml this needs a PR as well with your changes. /hack you do not need to modify |
2c6d273
to
f13ab7b
Compare
diff is zero so /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist