Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings after kustomize build in contrib #2992

Merged

Conversation

mahdikhashan
Copy link
Member

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Describe the changes you have made, including any refactoring or feature additions.

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

Link any issues that are resolved or affected by this PR.
resolves #2991

✅ Contributor Checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

…mization.yaml

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
@mahdikhashan mahdikhashan reopened this Feb 13, 2025
@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Feb 13, 2025
@mahdikhashan mahdikhashan changed the title fix warnings after kustomize build fix warnings after kustomize build in contrib Feb 13, 2025
@mahdikhashan mahdikhashan marked this pull request as ready for review February 13, 2025 13:07
@juliusvonkohout
Copy link
Member

You also need to raise it in the upstream repository see https://github.com/kubeflow/manifests/blob/master/hack/synchronize-kserve-web-app-manifests.sh

@mahdikhashan
Copy link
Member Author

You also need to raise it in the upstream repository see https://github.com/kubeflow/manifests/blob/master/hack/synchronize-kserve-web-app-manifests.sh

thank you - i'll do so and make sure the output stays the same.

@juliusvonkohout
Copy link
Member

diff -u can help a lot :-D You can upload the diff here as well.

@mahdikhashan
Copy link
Member Author

diff -u can help a lot :-D You can upload the diff here as well.

thanks for your help - the diff command result was empty for the build before and after the update. Its safe then, regarding the script, i also ran it with the latest commit for the 0.13.0-rc0 and there were no changes.

@juliusvonkohout
Copy link
Member

Here is the upstream file https://github.com/kserve/models-web-app/blob/master/config/base/kustomization.yaml this needs a PR as well with your changes. /hack you do not need to modify

@juliusvonkohout
Copy link
Member

https://github.com/kserve/models-web-app/blob/master/config/overlays/kubeflow/kustomization.yaml as well

@juliusvonkohout
Copy link
Member

diff is zero so

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 78d3804 into kubeflow:master Feb 13, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the remaining Kustomize 5 warnings
2 participants