-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading metacontroller to v4.11.22 #2988
base: master
Are you sure you want to change the base?
Upgrading metacontroller to v4.11.22 #2988
Conversation
Reference here to a similar issue, started since metacontroller V3 , where metacontroller supports only watching CRDs. A possible solution is changing PPC parent resource to Kubeflow profiles instead of namespaces, and update the hook in upstream to be able to process namespace from Kubeflow profiles CRD . |
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
6b3ea65
to
5be8bb5
Compare
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Thank you for the effort. We definitely need to watch namespaces and should not change the order. Because in practice there will be many more profiles created after installing Kubeflow and the metacontroller. |
canonical/metacontroller-operator#84 Probably means that we have to switch from composite controller to decorator controller. This can be done in the same PR. |
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
@juliusvonkohout Thanks for feedback. I found a PR from canonical and done the changes here accordingly. |
apps/pipeline/upstream/third-party/metacontroller/base/cluster-role.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Thank you very much. Can you create the same PR against kubeflow/pipelines, such that we have it synchronized? Did you also try this locally with some pipelines in a fresh kind cluster? |
Thank you Julius, I created PR in KFP as well. I have installed this in a fresh Kind cluster and verified that secret is created. I will try to run some more pipelines locally as well. |
Please check kubeflow/pipelines#11656 (comment) |
/lgtm |
@tarekabouzeid can you fix the merge conflict? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
Upgrading metacontroller to v4.11.22 , issue
Upstream sync PR
📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist