Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSERVE: update the kserve m2m test with real Kubeflow namespaces #2936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KSERVE: update the kserve m2m test with real Kubeflow namespaces #2936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/kserve_m2m_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Deploy and test KServe with m2m auth in KinD
on:

Check warning on line 2 in .github/workflows/kserve_m2m_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand Down Expand Up @@ -43,11 +43,17 @@
- name: Install knative
run: ./tests/gh-actions/install_knative.sh

- name: Build & Apply manifests
- name: Install KServe
run: ./tests/gh-actions/install_kserve.sh

- name: Create test namespace
run: kubectl create ns kserve-test
- name: Install KF Multi Tenancy
run: ./tests/gh-actions/install_multi_tenancy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -

- name: Create KF Profile
run: kustomize build common/user-namespace/base | kubectl apply -f -

- name: Setup python 3.9
uses: actions/setup-python@v4
Expand All @@ -63,10 +69,10 @@
nohup kubectl port-forward --namespace istio-system svc/${INGRESS_GATEWAY_SERVICE} 8080:80 &
while ! curl localhost:8080; do echo waiting for port-forwarding; sleep 1; done; echo port-forwarding ready

- name: Run kserve tests with m2m token from SA default/default
- name: Run kserve tests with m2m token from SA kubeflow-user-example-com/default-editor
run: |
export KSERVE_INGRESS_HOST_PORT=localhost:8080
export KSERVE_M2M_TOKEN="$(kubectl -n default create token default)"
export KSERVE_M2M_TOKEN="$(kubectl -n kubeflow-user-example-com create token default-editor)"
cd ./contrib/kserve/tests && pytest . -vs --log-level info

- name: Run and fail kserve tests without kserve m2m token
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kserve_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Build & Apply KServe manifests in KinD
on:

Check warning on line 2 in .github/workflows/kserve_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand Down Expand Up @@ -37,7 +37,7 @@
run: ./tests/gh-actions/install_kserve.sh

- name: Create test namespace
run: kubectl create ns kserve-test
run: kubectl create ns kubeflow-user-example-com # warning, this is not a real KF profile

Check warning on line 40 in .github/workflows/kserve_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

40:56 [comments] too few spaces before comment

- name: Setup python 3.9
uses: actions/setup-python@v4
Expand Down
2 changes: 1 addition & 1 deletion contrib/kserve/tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
logging.basicConfig(level=logging.INFO)

KSERVE_NAMESPACE = "kserve"
KSERVE_TEST_NAMESPACE = "kserve-test"
KSERVE_TEST_NAMESPACE = "kubeflow-user-example-com"
MODEL_CLASS_NAME = "modelClass"


Expand Down
Loading