-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional checks for 2.0: leader-follower, statefulSet, cloud-integration configs #3066
Conversation
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
Conflicts |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7414 | Triggered | Google API Key | 496c294 | cost-analyzer/templates/cost-analyzer-deployment-template.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
/cherry-pick v2.0 |
/cherry-pick v2.1 |
…ation configs (#3066) * check for mutually exclusive values * add checks for leaderFollower and statefulSet deployments * add checks for leaderFollower and statefulSet deployments * reword checks * helm 3.13+ Co-authored-by: Chip Zoller <chipzoller@gmail.com> * spacing Co-authored-by: Chip Zoller <chipzoller@gmail.com> * cloud integration checks * cloud integration checks --------- Co-authored-by: Chip Zoller <chipzoller@gmail.com>
…ation configs (#3066) * check for mutually exclusive values * add checks for leaderFollower and statefulSet deployments * add checks for leaderFollower and statefulSet deployments * reword checks * helm 3.13+ Co-authored-by: Chip Zoller <chipzoller@gmail.com> * spacing Co-authored-by: Chip Zoller <chipzoller@gmail.com> * cloud integration checks * cloud integration checks --------- Co-authored-by: Chip Zoller <chipzoller@gmail.com>
…ation configs (#3066) (#3151) * check for mutually exclusive values * add checks for leaderFollower and statefulSet deployments * add checks for leaderFollower and statefulSet deployments * reword checks * helm 3.13+ * spacing * cloud integration checks * cloud integration checks --------- Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Chip Zoller <chipzoller@gmail.com>
…ation configs (#3066) (#3150) * check for mutually exclusive values * add checks for leaderFollower and statefulSet deployments * add checks for leaderFollower and statefulSet deployments * reword checks * helm 3.13+ * spacing * cloud integration checks * cloud integration checks --------- Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Chip Zoller <chipzoller@gmail.com>
What does this PR change?
Add additional checks for 2.0: leader-follower, statefulSet, cloud-integration configs
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Additional 2.0 upgrade checks for users that have leader-follower or statefulSet deployments enabled.
Added cloud-integration check for mutually exclusive methods of providing that configuration.
What risks are associated with merging this PR? What is required to fully test this PR?
None
How was this PR tested?
Helm upgrade with and without the relevant values. Output of those tests below.
Have you made an update to documentation? If so, please provide the corresponding PR.