-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some missing Helm values #3062
Add some missing Helm values #3062
Conversation
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller <chipzoller@gmail.com>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Google API Key | b0f89e1 | cost-analyzer/templates/cost-analyzer-deployment-template.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Signed-off-by: chipzoller <chipzoller@gmail.com>
Signed-off-by: chipzoller chipzoller@gmail.com
What does this PR change?
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
No impact other than good documentation.
Links to Issues or tickets this PR addresses or fixes
N/A
What risks are associated with merging this PR? What is required to fully test this PR?
No functional changes made.
How was this PR tested?
helm template
with current state of the values file.Have you made an update to documentation? If so, please provide the corresponding PR.
N/A