-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error messages #3056
Add error messages #3056
Conversation
/cherry-pick v2.0 |
1 similar comment
/cherry-pick v2.0 |
Add error messages
Add error messages Co-authored-by: Ashleigh <53843587+CampfireRemnants@users.noreply.github.com>
FYI calling the cherry pick bot has some finicky permissions requirements; users who call for it must be added directly and cannot be part of a team. |
^ That would have been nice info to get when I asked why it seemed not to be working in the UI repo, rather than two links to a docs page that I'd already read. Any chance you can add individuals from my team? Or do I need Thomas for that. |
We probably didn't know it was the case at that time because it was freshly implemented. I can add individuals. Who should be added? |
@rayhatfield @wolfeaustin @jjarrett21 and myself, please and thank you. |
Done |
What does this PR change?
Bumps the image tag with a new (semver compliant) Forecasting image that uses better http error codes and new more informative messages about things going wrong.
Does this PR rely on any other PRs?
https://github.com/kubecost/kubecost-modeling/pull/37
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Users should now receive the correct message for unsupported aggregations and a 501, a 400 and more informative error for malformed requests, and a 503 and helpful message when a valid model is untrained (usually courtesy of upstream data issues)
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
Pretty minimal risk
How was this PR tested?
Locally!
Have you made an update to documentation? If so, please provide the corresponding PR.
n/a