Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages #3056

Merged
1 commit merged into from
Feb 1, 2024
Merged

Add error messages #3056

1 commit merged into from
Feb 1, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 1, 2024

What does this PR change?

Bumps the image tag with a new (semver compliant) Forecasting image that uses better http error codes and new more informative messages about things going wrong.

Does this PR rely on any other PRs?

https://github.com/kubecost/kubecost-modeling/pull/37

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Users should now receive the correct message for unsupported aggregations and a 501, a 400 and more informative error for malformed requests, and a 503 and helpful message when a valid model is untrained (usually courtesy of upstream data issues)

Links to Issues or tickets this PR addresses or fixes

What risks are associated with merging this PR? What is required to fully test this PR?

Pretty minimal risk

How was this PR tested?

Locally!

Have you made an update to documentation? If so, please provide the corresponding PR.

n/a

@ghost ghost requested review from nealormsbee and cliffcolvin February 1, 2024 21:52
@ghost ghost self-assigned this Feb 1, 2024
@ghost ghost merged commit 1c920f3 into develop Feb 1, 2024
12 checks passed
@ghost ghost deleted the ashleigh/add-new-errors branch February 1, 2024 21:56
@ghost
Copy link
Author

ghost commented Feb 1, 2024

/cherry-pick v2.0

1 similar comment
@chipzoller
Copy link
Collaborator

/cherry-pick v2.0

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 1, 2024
chipzoller pushed a commit that referenced this pull request Feb 1, 2024
Add error messages

Co-authored-by: Ashleigh <53843587+CampfireRemnants@users.noreply.github.com>
@chipzoller
Copy link
Collaborator

FYI calling the cherry pick bot has some finicky permissions requirements; users who call for it must be added directly and cannot be part of a team.

@nealormsbee
Copy link
Member

^ That would have been nice info to get when I asked why it seemed not to be working in the UI repo, rather than two links to a docs page that I'd already read.

Any chance you can add individuals from my team? Or do I need Thomas for that.

@chipzoller
Copy link
Collaborator

^ That would have been nice info to get when I asked why it seemed not to be working in the UI repo, rather than two links to a docs page that I'd already read.

We probably didn't know it was the case at that time because it was freshly implemented.

I can add individuals. Who should be added?

@nealormsbee
Copy link
Member

@rayhatfield @wolfeaustin @jjarrett21 and myself, please and thank you.

@chipzoller
Copy link
Collaborator

Done

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants