Update to check if saml is enabled, not just if the object exists. #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saweber
approved these changes
Jan 29, 2024
|
/cherry-pick v2.0 |
ameijer
pushed a commit
that referenced
this pull request
Jan 31, 2024
…host-1141-yaml-actions * commit '9abf05499eab352d9a10590c282e8e9491939804': updated release note (#3027) Bumped image tag with tighter prediction interval (#3023) Bumped image tag with retry changes (#3021) Bump thanosio/thanos from v0.32.5 to v0.34.0 in /cost-analyzer (#3015) Bump grafana/grafana from 10.2.3 to 10.3.1 in /cost-analyzer (#3013) Bump prometheus/alertmanager from v0.25.0 to v0.26.0 in /cost-analyzer (#2914) Bump prometheus-operator/prometheus-config-reloader in /cost-analyzer (#3014) Fix 2.0 precondition for nightly environment (#3016) Enable forecasting by default, fix "early spike" forecast behavior (#3010) [GTM-199] take global annotations setting into etlutils (#3006) Update to check if saml is enabled, not just if the object exists. (#3005) block thanos agent upgrades and suggest fedetl (#2998) Move 2.0 precondition checks into a function (#2986)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Update to check if saml is enabled, not just if the object exists.
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
For non-SAML users, an unnecessary secret will not be created
Links to Issues or tickets this PR addresses or fixes
None
What risks are associated with merging this PR? What is required to fully test this PR?
I observed that the
kubecost-samlsecret was being created even in the default nightly install:I have not yet tested an install on a SAML setup, or a standard Kubecost Enterprise which may have a hidden dependency on this secret. @saweber Do you have any insight here?
How was this PR tested?
TODO?
Have you made an update to documentation? If so, please provide the corresponding PR.
Not needed