Fix duplicate Prom configmap reloader securitycontext #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chipzoller <chipzoller@gmail.com>
2 tasks
|
ConfigMap reloader was decided to be disabled by default rather than removed. See #2994. |
jessegoodier
approved these changes
Jan 29, 2024
|
/cherry-pick v2.0 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Signed-off-by: chipzoller <chipzoller@gmail.com>
jessegoodier
pushed a commit
that referenced
this pull request
Jan 29, 2024
ameijer
pushed a commit
that referenced
this pull request
Jan 29, 2024
…host-1141-yaml-actions * commit '387531c0e4430b593509298519b8477fec65a0cf': fix duplicate sc (#2930) disable configmapReloader by default (#2994) federatedETL agent (#2995) Bump prometheus/prometheus from v2.48.1 to v2.49.1 in /cost-analyzer (#2931) Bump grafana/grafana from 10.2.2 to 10.2.3 in /cost-analyzer (#2913) multi-cluster prometheus check (#2975) Proxy /model/diagnostic/coreCount to aggregator (#2988) rbac upgrade check (#2981) Bump forecasting with error codes update (#2984) ssoEnabled flag (#2982) Bump forecasting image (#2979) Update broken link for diagnostics (#2977) Sensible error on /forecasting if forecasting is disabled (instead of index.html) (#2976) Update modeling image: resilient to bad training data and CC endpoint behavior (#2973) Update modeling image with training (#2971) Set Gunicorn worker timeout to 1200 seconds (#2967) Return descriptive error if user is running Aggregator in v1.x and attempting to upgrade to 2.0 (#2964) disable node exporter by default (#2965) Update kubecost-modeling to API-stable version (#2962)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chipzoller chipzoller@gmail.com
What does this PR change?
Removes a redundant if clause and fixes a duplicate securityContext entry in Prometheus' configmap reloader container.
Does this PR rely on any other PRs?
No, but these changes may be obviated if the intention in 2.0 is to remove the configmap reloader, in which case this is throw-away work.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Allows Prometheus to deploy correctly if the global level containerSecurityContext is not defined (not default).
Links to Issues or tickets this PR addresses or fixes
Fixes #2926
What risks are associated with merging this PR? What is required to fully test this PR?
May still deploy incorrectly.
How was this PR tested?
Helm templating with various settings.
Have you made an update to documentation? If so, please provide the corresponding PR.
N/A