helm changes to add enterprise network enabled flag #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avrodrigues5
force-pushed
the
avr/enable_enterpise_networking_flag
branch
from
c4bf4b6 to
890e672
Compare
| {{- if .Values.networkCosts.config.services }} | ||
| {{- $services := .Values.networkCosts.config.services -}} | ||
| {{- if or (index $services "google-cloud-services") (index $services "aws-cloud-services") (index $services "azure-cloud-services")}} | ||
| - name: ENTERPRISE_NETWORK_ENABLED |
There was a problem hiding this comment.
Maybe "ADVANCED_NETWORK_STATS"? Can you also leave a comment on what this does?
There was a problem hiding this comment.
done , please review it again!
avrodrigues5
force-pushed
the
avr/enable_enterpise_networking_flag
branch
from
aa49344 to
0780de8
Compare
…ed with suffix -cloud-services, hence correcting the helm flag setting
AjayTripathy
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Enabled enterprise network when and of the service tagging is enabled https://docs.kubecost.com/install-and-configure/advanced-configuration/network-costs-configuration#cloud-provider-service-tagging
Does this PR rely on any other PRs?
KCM PR
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Have ability to enable enterprise networking
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
How was this PR tested?
In my cluster helm upgrading with the helm values
Have you made an update to documentation? If so, please provide the corresponding PR.
Not yet!