Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run e2e tests on feature images #89

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: run e2e tests on feature images #89

merged 2 commits into from
Oct 31, 2024

Conversation

csatib02
Copy link
Member

Overview

  • This PR fixes an issue with e2e tests not being run on feature images.
  • Also did some janitorial work around makefile deps

Fixes: #87

Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 added bug Something isn't working enhancement New feature or request labels Oct 31, 2024
@csatib02 csatib02 self-assigned this Oct 31, 2024
@csatib02 csatib02 requested review from kristofgyuracz, OverOrion and pepov and removed request for kristofgyuracz and OverOrion October 31, 2024 13:29
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
Copy link
Collaborator

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@csatib02 csatib02 merged commit 90935e5 into main Oct 31, 2024
11 checks passed
@csatib02 csatib02 deleted the fix/e2e-tests branch October 31, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The e2e test is not being run on feature images
2 participants