Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exporters): working loki exporter #41

Merged
merged 15 commits into from
Mar 26, 2024
Merged

feat(exporters): working loki exporter #41

merged 15 commits into from
Mar 26, 2024

Conversation

kristofgyuracz
Copy link
Collaborator

No description provided.

@kristofgyuracz kristofgyuracz force-pushed the loki branch 5 times, most recently from 92c54bc to a04f713 Compare March 19, 2024 15:44
@kristofgyuracz kristofgyuracz changed the title wip feat(exporters): working loki exporter Mar 19, 2024
@kristofgyuracz kristofgyuracz marked this pull request as ready for review March 19, 2024 15:52
kristofgyuracz and others added 10 commits March 25, 2024 12:56
@kristofgyuracz
feat(exporters): working loki exporter
b67cad6 
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@pepov @kristofgyuracz
example yaml and scripts
a5ff857 
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@tarokkk @kristofgyuracz
add tenant into loki labels (temporary)
d39a598 
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@pepov @kristofgyuracz
loki demo setup script updates
a9a111d 
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz
update test
1429941 
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@pepov @kristofgyuracz
rename demo resources to be simpler to understand
e9471ee 
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@pepov @kristofgyuracz
add telemetry-all category to outputss
2a0f36d 
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@pepov @kristofgyuracz
add openobserve outputs
c191a90 
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@pepov @kristofgyuracz
add missing subscription namespace everywhere
bd52741 
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@pepov @kristofgyuracz
rename resources once again
04d835f 
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz
update tests
90412bf 
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz kristofgyuracz requested a review from pepov March 25, 2024 13:06
pepov
pepov approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few nits

api/telemetry/v1alpha1/collector_types.go Outdated Show resolved Hide resolved
internal/controller/telemetry/otel_conf_gen.go Outdated Show resolved Hide resolved
internal/controller/telemetry/otel_conf_gen.go Outdated Show resolved Hide resolved
@kristofgyuracz
panic on yaml unmarshal error
2d4fe1b 
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz
comments
7984af4 
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
OverOrion
OverOrion approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only version alignments needed

docs/demos/loki/setup.sh Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@kristofgyuracz
update versions everywhere
1b29dbd 
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz
improve logging
ca0b4e7 
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz kristofgyuracz merged commit 07d030a into main Mar 26, 2024
12 checks passed
@kristofgyuracz kristofgyuracz deleted the loki branch March 26, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@OverOrion OverOrion OverOrion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristofgyuracz @pepov @OverOrion @tarokkk