Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update CI workflows to use Nodejs v20 #27

Merged
merged 2 commits into from
Mar 28, 2024
Merged

chore(deps): update CI workflows to use Nodejs v20 #27

merged 2 commits into from
Mar 28, 2024

Conversation

OverOrion
Copy link
Collaborator

@OverOrion OverOrion commented Feb 5, 2024 •
edited
Loading

  • Wait until azure/setup-kubectl@v4 is available

@OverOrion OverOrion force-pushed the actions-nodejs20 branch 2 times, most recently from 3330d21 to d487df8 Compare February 8, 2024 08:36
@OverOrion
Copy link
Collaborator Author

OverOrion commented Feb 8, 2024 •
edited
Loading

upload-artifact/v4 breaking changes:

Uploading to the same named Artifact multiple times.
Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

https://github.com/actions/upload-artifact

Will have to do a followup.

@OverOrion OverOrion marked this pull request as ready for review February 9, 2024 09:25
@OverOrion OverOrion marked this pull request as draft February 9, 2024 10:50
@OverOrion
Copy link
Collaborator Author

OverOrion commented Feb 9, 2024 •
edited
Loading

There are still some actions using Nodejs v16, and a refactor might be needed for action-cond.
EDIT: action-cond's new release just became available

@OverOrion OverOrion marked this pull request as ready for review February 14, 2024 07:25
@OverOrion
chore(deps): update CI workflows to use Nodejs v20
06ce970 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion
fix(CI): followup on upload-artifact@v4's changes
45acef6 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion OverOrion merged commit ccde13c into main Mar 28, 2024
12 checks passed
@OverOrion OverOrion deleted the actions-nodejs20 branch March 28, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OverOrion @pepov