Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select all log source namespaces #110

Merged
merged 6 commits into from
Dec 6, 2024
Merged

fix: select all log source namespaces #110

merged 6 commits into from
Dec 6, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Dec 5, 2024 •
edited
Loading

#92 mistakenly removed the ability to select all namespaces, this PR adds that back.

To use this, specify the logSourceNamespaceSelectors field with an empty slice.

apiVersion: telemetry.kube-logging.dev/v1alpha1
kind: Tenant
metadata:
  labels:
    collector: cluster
  name: tenant
spec:
  logSourceNamespaceSelectors: []

Also made the Collector CR's ControlNamespace field immutable.

@csatib02 csatib02 added the bug Something isn't working label Dec 5, 2024
@csatib02 csatib02 requested review from pepov and OverOrion December 5, 2024 13:25
@csatib02 csatib02 self-assigned this Dec 5, 2024
@csatib02 csatib02 marked this pull request as ready for review December 5, 2024 13:25
@pepov
Copy link
Member

pepov commented Dec 5, 2024

as discussed: please add doc comments and make sure the behaviour is consistent with how subscriptionNamespaceSelectors behaves

@csatib02
fix: re-enable selecting logs from all namespaces
7d94612 
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02
chore: add devspace to gitignore
3bbf53f 
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02
chore: bump dependency-chart
e1de0f9 
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02
chore: add docs
caf669c 
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 requested a review from pepov December 6, 2024 13:39
@csatib02
chore: update Chart.yaml
723651b 
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02
feat: make control namespace field immutable
63a4b7c 
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 merged commit 910ae7a into main Dec 6, 2024
20 checks passed
@csatib02 csatib02 deleted the fix/select-all-ns branch December 6, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverOrion OverOrion OverOrion approved these changes

@pepov pepov Awaiting requested review from pepov

Assignees

@csatib02 csatib02

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csatib02 @pepov @OverOrion